Fix #1708 - Don't modify linters or register fixers in the sandbox

2 files changed, 15 insertions, 0 deletions

diff --git a/autoload/ale/fix/registry.vim b/autoload/ale/fix/registry.vim
index 539234c0..e148ecd6 100644
--- a/autoload/ale/fix/registry.vim
+++ b/autoload/ale/fix/registry.vim
@@ -242,6 +242,9 @@ endfunction
 " Add a function for fixing problems to the registry.
 " (name, func, filetypes, desc, aliases)
 function! ale#fix#registry#Add(name, func, filetypes, desc, ...) abort
+    " This command will throw from the sandbox.
+    let &equalprg=&equalprg
+
     if type(a:name) != type('')
         throw '''name'' must be a String'
     endif
diff --git a/autoload/ale/linter.vim b/autoload/ale/linter.vim
index 22e3c5dc..aa602f7e 100644
--- a/autoload/ale/linter.vim
+++ b/autoload/ale/linter.vim
@@ -50,6 +50,9 @@ endfunction
 " This is only for tests.
 " Do not call this function.
 function! ale#linter#GetLintersLoaded() abort
+    " This command will throw from the sandbox.
+    let &equalprg=&equalprg
+
     return s:linters
 endfunction
 
@@ -289,6 +292,9 @@ function! ale#linter#PreProcess(filetype, linter) abort
 endfunction
 
 function! ale#linter#Define(filetype, linter) abort
+    " This command will throw from the sandbox.
+    let &equalprg=&equalprg
+
     if !has_key(s:linters, a:filetype)
         let s:linters[a:filetype] = []
     endif
@@ -304,6 +310,12 @@ function! ale#linter#PreventLoading(filetype) abort
 endfunction
 
 function! ale#linter#GetAll(filetypes) abort
+    " Don't return linters in the sandbox.
+    " Otherwise a sandboxed script could modify them.
+    if ale#util#InSandbox()
+        return []
+    endif
+
     let l:combined_linters = []
 
     for l:filetype in a:filetypes