diff options
author | Wez Furlong <wez@wezfurlong.org> | 2019-07-23 23:51:24 -0700 |
---|---|---|
committer | Wez Furlong <wez@wezfurlong.org> | 2019-07-29 08:55:06 -0700 |
commit | dfcba59b6a77d9a730ed8d6b6728d8812ece424b (patch) | |
tree | a60942b1ef1d25a947c871b42d1509ab7bbd7da2 /.gitignore | |
parent | 9efb2d664971682278b37eb40152c27f6e231645 (diff) | |
download | ssh2-rs-dfcba59b6a77d9a730ed8d6b6728d8812ece424b.zip |
Make channel tests more robust to stderr output
At the start of feb 2019 the tests started to fail on macos on Travis. No
changes were made to the repo, so the problem must be environmental.
It turns out that the server was emitting stderr output, and since the
tests were not consuming stderr, this made `channel.eof()` always
return false.
The resolution is to drain both stdout and stderr in the tests before
making assertions with `channel.eof()`.
I've also updated the doc comment on `channel.eof()` to reflect this,
as it is a bit of a sharp edge.
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions