1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
|
Before:
Save g:ale_warn_about_trailing_blank_lines
Save g:ale_warn_about_trailing_whitespace
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
runtime ale_linters/python/flakehell.vim
After:
Restore
unlet! b:ale_warn_about_trailing_blank_lines
unlet! b:ale_warn_about_trailing_whitespace
call ale#linter#Reset()
Execute(The flakehell handler should handle basic warnings and syntax errors):
AssertEqual
\ [
\ {
\ 'lnum': 6,
\ 'col': 6,
\ 'vcol': 1,
\ 'type': 'E',
\ 'text': 'indentation is not a multiple of four',
\ 'code': 'E111',
\ 'sub_type': 'style',
\ },
\ {
\ 'lnum': 7,
\ 'col': 6,
\ 'vcol': 1,
\ 'type': 'W',
\ 'text': 'some warning',
\ 'code': 'W123',
\ 'sub_type': 'style',
\ },
\ {
\ 'lnum': 8,
\ 'col': 3,
\ 'vcol': 1,
\ 'type': 'E',
\ 'text': 'SyntaxError: invalid syntax',
\ 'code': 'E999',
\ },
\ ],
\ ale_linters#python#flakehell#Handle(1, [
\ 'stdin:6:6: E111 indentation is not a multiple of four',
\ 'stdin:7:6: W123 some warning',
\ 'stdin:8:3: E999 SyntaxError: invalid syntax',
\ ])
Execute(The flakehell handler should set end column indexes for certain errors):
AssertEqual
\ [
\ {
\ 'lnum': 25,
\ 'col': 1,
\ 'vcol': 1,
\ 'type': 'E',
\ 'end_col': 3,
\ 'text': 'undefined name ''foo''',
\ 'code': 'F821',
\ },
\ {
\ 'lnum': 28,
\ 'col': 5,
\ 'vcol': 1,
\ 'type': 'E',
\ 'end_col': 9,
\ 'text': 'hello may be undefined, or defined from star imports: x',
\ 'code': 'F405',
\ },
\ {
\ 'lnum': 104,
\ 'col': 5,
\ 'vcol': 1,
\ 'type': 'E',
\ 'end_col': 12,
\ 'text': '''continue'' not properly in loop',
\ 'code': 'F999',
\ },
\ {
\ 'lnum': 106,
\ 'col': 5,
\ 'vcol': 1,
\ 'type': 'E',
\ 'end_col': 9,
\ 'text': '''break'' outside loop',
\ 'code': 'F999',
\ },
\ {
\ 'lnum': 109,
\ 'col': 5,
\ 'vcol': 1,
\ 'type': 'E',
\ 'end_col': 8,
\ 'text': 'local variable ''test'' is assigned to but never used',
\ 'code': 'F841',
\ },
\ ],
\ ale_linters#python#flakehell#Handle(1, [
\ 'foo.py:25:1: F821 undefined name ''foo''',
\ 'foo.py:28:5: F405 hello may be undefined, or defined from star imports: x',
\ 'foo.py:104:5: F999 ''continue'' not properly in loop',
\ 'foo.py:106:5: F999 ''break'' outside loop',
\ 'foo.py:109:5: F841 local variable ''test'' is assigned to but never used',
\ ])
Execute(The flakehell handler should handle stack traces):
AssertEqual
\ [
\ {
\ 'lnum': 1,
\ 'text': 'ImportError: No module named parser (See :ALEDetail)',
\ 'detail': join([
\ 'Traceback (most recent call last):',
\ ' File "/usr/local/bin/flakehell", line 7, in <module>',
\ ' from flakehell.main.cli import main',
\ ' File "/usr/local/lib/python2.7/dist-packages/flakehell/main/cli.py", line 2, in <module>',
\ ' from flakehell.main import application',
\ ' File "/usr/local/lib/python2.7/dist-packages/flakehell/main/application.py", line 17, in <module>',
\ ' from flakehell.plugins import manager as plugin_manager',
\ ' File "/usr/local/lib/python2.7/dist-packages/flakehell/plugins/manager.py", line 5, in <module>',
\ ' import pkg_resources',
\ ' File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 35, in <module>',
\ ' import email.parser',
\ 'ImportError: No module named parser',
\ ], "\n"),
\ },
\ ],
\ ale_linters#python#flakehell#Handle(42, [
\ 'Traceback (most recent call last):',
\ ' File "/usr/local/bin/flakehell", line 7, in <module>',
\ ' from flakehell.main.cli import main',
\ ' File "/usr/local/lib/python2.7/dist-packages/flakehell/main/cli.py", line 2, in <module>',
\ ' from flakehell.main import application',
\ ' File "/usr/local/lib/python2.7/dist-packages/flakehell/main/application.py", line 17, in <module>',
\ ' from flakehell.plugins import manager as plugin_manager',
\ ' File "/usr/local/lib/python2.7/dist-packages/flakehell/plugins/manager.py", line 5, in <module>',
\ ' import pkg_resources',
\ ' File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 35, in <module>',
\ ' import email.parser',
\ 'ImportError: No module named parser',
\ ])
Execute(The flakehell handler should handle names with spaces):
AssertEqual
\ [
\ {
\ 'lnum': 6,
\ 'col': 6,
\ 'vcol': 1,
\ 'type': 'E',
\ 'text': 'indentation is not a multiple of four',
\ 'code': 'E111',
\ 'sub_type': 'style',
\ },
\ ],
\ ale_linters#python#flakehell#Handle(42, [
\ 'C:\something\with spaces.py:6:6: E111 indentation is not a multiple of four',
\ ])
Execute(Warnings about trailing whitespace should be reported by default):
AssertEqual
\ [
\ {
\ 'lnum': 6,
\ 'col': 1,
\ 'vcol': 1,
\ 'code': 'W291',
\ 'type': 'W',
\ 'sub_type': 'style',
\ 'text': 'who cares',
\ },
\ {
\ 'lnum': 6,
\ 'col': 1,
\ 'vcol': 1,
\ 'code': 'W293',
\ 'type': 'W',
\ 'sub_type': 'style',
\ 'text': 'who cares',
\ },
\ ],
\ ale_linters#python#flakehell#Handle(bufnr(''), [
\ 'foo.py:6:1: W291 who cares',
\ 'foo.py:6:1: W293 who cares',
\ ])
Execute(Disabling trailing whitespace warnings should work):
let b:ale_warn_about_trailing_whitespace = 0
AssertEqual
\ [
\ ],
\ ale_linters#python#flakehell#Handle(bufnr(''), [
\ 'foo.py:6:1: W291 who cares',
\ 'foo.py:6:1: W293 who cares',
\ ])
Execute(Warnings about trailing blank lines should be reported by default):
AssertEqual
\ [
\ {
\ 'lnum': 6,
\ 'col': 1,
\ 'vcol': 1,
\ 'code': 'W391',
\ 'type': 'W',
\ 'sub_type': 'style',
\ 'text': 'blank line at end of file',
\ },
\ ],
\ ale_linters#python#flakehell#Handle(bufnr(''), [
\ 'foo.py:6:1: W391 blank line at end of file',
\ ])
Execute(Disabling trailing blank line warnings should work):
let b:ale_warn_about_trailing_blank_lines = 0
AssertEqual
\ [
\ ],
\ ale_linters#python#flakehell#Handle(bufnr(''), [
\ 'foo.py:6:1: W391 blank line at end of file',
\ ])
Execute(F401 should be a warning):
AssertEqual
\ [
\ {
\ 'lnum': 6,
\ 'col': 1,
\ 'vcol': 1,
\ 'code': 'F401',
\ 'type': 'W',
\ 'text': 'module imported but unused',
\ },
\ ],
\ ale_linters#python#flakehell#Handle(bufnr(''), [
\ 'foo.py:6:1: F401 module imported but unused',
\ ])
Execute(E112 should be a syntax error):
AssertEqual
\ [
\ {
\ 'lnum': 6,
\ 'col': 1,
\ 'vcol': 1,
\ 'code': 'E112',
\ 'type': 'E',
\ 'text': 'expected an indented block',
\ },
\ ],
\ ale_linters#python#flakehell#Handle(bufnr(''), [
\ 'foo.py:6:1: E112 expected an indented block',
\ ])
Execute(Compatibility with hacking which uses older style flakehell):
AssertEqual
\ [
\ {
\ 'lnum': 6,
\ 'col': 1,
\ 'vcol': 1,
\ 'code': 'H306',
\ 'type': 'W',
\ 'text': 'imports not in alphabetical order (smtplib, io)',
\ },
\ ],
\ ale_linters#python#flakehell#Handle(bufnr(''), [
\ 'foo.py:6:1: H306: imports not in alphabetical order (smtplib, io)',
\ ])
|
