Remove features deprecated in previous versions

1 files changed, 55 insertions, 332 deletions

diff --git a/test/test_linter_defintion_processing.vader b/test/test_linter_defintion_processing.vader
index cd32ebc8..2c85299b 100644
--- a/test/test_linter_defintion_processing.vader
+++ b/test/test_linter_defintion_processing.vader
@@ -39,13 +39,13 @@ Execute (PreProcess should throw when then callback is not a function):
   \})
   AssertEqual '`callback` must be defined with a callback to accept output', g:vader_exception
 
-Execute (PreProcess should throw when there is no executable or executable_callback):
+Execute (PreProcess should throw when there is no executable):
   AssertThrows call ale#linter#PreProcess('testft', {
   \ 'name': 'foo',
   \ 'callback': 'SomeFunction',
   \ 'command': 'echo',
   \})
-  AssertEqual 'Either `executable` or `executable_callback` must be defined', g:vader_exception
+  AssertEqual '`executable` must be defined', g:vader_exception
 
 Execute (PreProcess should throw when executable is not a string):
   AssertThrows call ale#linter#PreProcess('testft', {
@@ -56,15 +56,6 @@ Execute (PreProcess should throw when executable is not a string):
   \})
   AssertEqual '`executable` must be a String or Function if defined', g:vader_exception
 
-Execute (PreProcess should throw when executable_callback is not a callback):
-  AssertThrows call ale#linter#PreProcess('testft', {
-  \ 'name': 'foo',
-  \ 'callback': 'SomeFunction',
-  \ 'executable_callback': 123,
-  \ 'command': 'echo',
-  \})
-  AssertEqual '`executable_callback` must be a callback if defined', g:vader_exception
-
 Execute (PreProcess should allow executable to be a callback):
   call ale#linter#PreProcess('testft', {
   \ 'name': 'foo',
@@ -79,7 +70,7 @@ Execute (PreProcess should throw when there is no command):
   \ 'callback': 'SomeFunction',
   \ 'executable': 'echo',
   \})
-  AssertEqual 'Either `command`, `executable_callback`, `command_chain` must be defined', g:vader_exception
+  AssertEqual '`command` must be defined', g:vader_exception
 
 Execute (PreProcess should throw when command is not a string):
   AssertThrows call ale#linter#PreProcess('testft', {
@@ -98,15 +89,6 @@ Execute (PreProcess should allow command to be a callback):
   \ 'command': function('type'),
   \})
 
-Execute (PreProcess should throw when command_callback is not a callback):
-  AssertThrows call ale#linter#PreProcess('testft', {
-  \ 'name': 'foo',
-  \ 'callback': 'SomeFunction',
-  \ 'executable': 'echo',
-  \ 'command_callback': 123,
-  \})
-  AssertEqual '`command_callback` must be a callback if defined', g:vader_exception
-
 Execute (PreProcess should when the output stream isn't a valid string):
   AssertThrows call ale#linter#PreProcess('testft', {
   \ 'name': 'foo',
@@ -152,117 +134,12 @@ Execute (PreProcess should accept a 'both' output_stream):
   \ 'output_stream': 'both',
   \})
 
-Execute(PreProcess should complain if the command_chain is not a List):
-  let g:linter = {
-  \ 'name': 'x',
-  \ 'callback': 'x',
-  \ 'executable': 'x',
-  \ 'command_chain': 'x',
-  \}
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual '`command_chain` must be a List', g:vader_exception
-
-Execute(PreProcess should complain if the command_chain is empty):
-  let g:linter = {
-  \ 'name': 'x',
-  \ 'callback': 'x',
-  \ 'executable': 'x',
-  \ 'command_chain': [],
-  \}
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual '`command_chain` must contain at least one item', g:vader_exception
-
-Execute(PreProcess should complain if the command_chain has no callback):
-  let g:linter = {
-  \ 'name': 'x',
-  \ 'callback': 'x',
-  \ 'executable': 'x',
-  \ 'command_chain': [{}],
-  \}
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual 'The `command_chain` item 0 must define a `callback` function', g:vader_exception
-
-Execute(PreProcess should complain if the command_chain callback is not a function):
-  let g:linter = {
-  \ 'name': 'x',
-  \ 'callback': 'x',
-  \ 'executable': 'x',
-  \ 'command_chain': [{'callback': 2}],
-  \}
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual 'The `command_chain` item 0 must define a `callback` function', g:vader_exception
-
-Execute(PreProcess should accept a chain with one callback):
-  let g:linter = {
-  \ 'name': 'x',
-  \ 'callback': 'x',
-  \ 'executable': 'x',
-  \ 'command_chain': [{'callback': 'foo'}],
-  \}
-  call ale#linter#PreProcess('testft', g:linter)
-
-Execute(PreProcess should complain about invalid output_stream values in the chain):
-  let g:linter = {
-  \ 'name': 'x',
-  \ 'callback': 'x',
-  \ 'executable': 'x',
-  \ 'command_chain': [{'callback': 'foo', 'output_stream': ''}],
-  \}
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual "The `command_chain` item 0 `output_stream` flag must be 'stdout', 'stderr', or 'both'", g:vader_exception
-
-Execute(PreProcess should complain about valid output_stream values in the chain):
-  let g:linter = {
-  \ 'name': 'x',
-  \ 'callback': 'x',
-  \ 'executable': 'x',
-  \ 'command_chain': [{'callback': 'foo', 'output_stream': 'stdout'}],
-  \}
-  call ale#linter#PreProcess('testft', g:linter)
-  let g:linter.command_chain[0].output_stream = 'stderr'
-  call ale#linter#PreProcess('testft', g:linter)
-  let g:linter.command_chain[0].output_stream = 'both'
-  call ale#linter#PreProcess('testft', g:linter)
-
-Execute(PreProcess should complain about invalid chain items at higher indices):
-  let g:linter = {
-  \ 'name': 'x',
-  \ 'callback': 'x',
-  \ 'executable': 'x',
-  \ 'command_chain': [{'callback': 'foo'}, {'callback': 123}],
-  \}
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual 'The `command_chain` item 1 must define a `callback` function', g:vader_exception
-
-Execute(PreProcess should complain when conflicting command options are used):
-  let g:linter = {
-  \ 'name': 'x',
-  \ 'callback': 'x',
-  \ 'executable': 'x',
-  \ 'command': 'foo',
-  \ 'command_chain': [{'callback': 'foo'}],
-  \}
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual 'Only one of `command`, `command_callback`, or `command_chain` should be set', g:vader_exception
-
-  unlet g:linter.command
-  let g:linter.command_callback = 'foo'
-
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual 'Only one of `command`, `command_callback`, or `command_chain` should be set', g:vader_exception
-
-  let g:linter.command = 'foo'
-  unlet g:linter.command_chain
-
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual 'Only one of `command`, `command_callback`, or `command_chain` should be set', g:vader_exception
-
 Execute(PreProcess should process the read_buffer option correctly):
   let g:linter = {
   \ 'name': 'x',
   \ 'callback': 'x',
   \ 'executable': 'x',
-  \ 'command_chain': [{'callback': 'foo'}, {'callback': 'bar'}],
+  \ 'command': 'x',
   \ 'read_buffer': '0',
   \}
 
@@ -277,25 +154,6 @@ Execute(PreProcess should process the read_buffer option correctly):
 
   call ale#linter#PreProcess('testft', g:linter)
 
-  unlet g:linter.read_buffer
-  let g:linter.command_chain[0].read_buffer = '0'
-
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual 'The `command_chain` item 0 value for `read_buffer` must be `0` or `1`', g:vader_exception
-
-  let g:linter.command_chain[0].read_buffer = 0
-
-  call ale#linter#PreProcess('testft', g:linter)
-
-  let g:linter.command_chain[1].read_buffer = '0'
-
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual 'The `command_chain` item 1 value for `read_buffer` must be `0` or `1`', g:vader_exception
-
-  let g:linter.command_chain[1].read_buffer = 1
-
-  call ale#linter#PreProcess('testft', g:linter)
-
 Execute(PreProcess should set a default value for read_buffer):
   let g:linter = {
   \ 'name': 'x',
@@ -394,151 +252,96 @@ Execute(PreProcess should accept tsserver LSP configuration):
   \ 'executable': 'x',
   \ 'command': 'x',
   \ 'lsp': 'tsserver',
-  \ 'language_callback': 'x',
-  \ 'project_root_callback': 'x',
+  \ 'language': 'x',
+  \ 'project_root': 'x',
   \}
 
   AssertEqual 'tsserver', ale#linter#PreProcess('testft', g:linter).lsp
 
-  call remove(g:linter, 'executable')
-  let g:linter.executable_callback = 'X'
-
-  call ale#linter#PreProcess('testft', g:linter)
-
-  call remove(g:linter, 'command')
-  let g:linter.command_callback = 'X'
-
-  call ale#linter#PreProcess('testft', g:linter)
-
 Execute(PreProcess should accept stdio LSP configuration):
   let g:linter = {
   \ 'name': 'x',
   \ 'executable': 'x',
   \ 'command': 'x',
   \ 'lsp': 'stdio',
-  \ 'language_callback': 'x',
-  \ 'project_root_callback': 'x',
+  \ 'language': 'x',
+  \ 'project_root': 'x',
   \}
 
   AssertEqual 'stdio', ale#linter#PreProcess('testft', g:linter).lsp
 
-  call remove(g:linter, 'executable')
-  let g:linter.executable_callback = 'X'
-
-  call ale#linter#PreProcess('testft', g:linter)
-
-  call remove(g:linter, 'command')
-  let g:linter.command_callback = 'X'
-
-  call ale#linter#PreProcess('testft', g:linter)
-
 Execute(PreProcess should accept LSP server configurations):
   let g:linter = {
   \ 'name': 'x',
   \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
-  \ 'language_callback': 'x',
-  \ 'project_root_callback': 'x',
-  \}
-
-  AssertEqual 'socket', ale#linter#PreProcess('testft', g:linter).lsp
-
-Execute(PreProcess should accept let you specify the language as just a string):
-  let g:linter = {
-  \ 'name': 'x',
-  \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
+  \ 'address': 'X',
   \ 'language': 'foobar',
-  \ 'project_root_callback': 'x',
+  \ 'project_root': 'x',
   \}
 
-  AssertEqual 'foobar', ale#linter#PreProcess('testft', g:linter).language_callback(0)
+  AssertEqual 'socket', ale#linter#PreProcess('testft', g:linter).lsp
 
-Execute(PreProcess should complain about using language and language_callback together):
+Execute(PreProcess should accept let you specify the `language` as a Function):
   let g:linter = {
   \ 'name': 'x',
   \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
-  \ 'language': 'x',
-  \ 'language_callback': 'x',
-  \ 'project_root_callback': 'x',
+  \ 'address': 'X',
+  \ 'language': {-> 'foobar'},
+  \ 'project_root': 'x',
   \}
 
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual 'Only one of `language` or `language_callback` should be set', g:vader_exception
+  AssertEqual 'foobar', ale#linter#PreProcess('testft', g:linter).language(bufnr(''))
 
 Execute(PreProcess should complain about invalid language values):
   let g:linter = {
   \ 'name': 'x',
   \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
+  \ 'address': 'X',
   \ 'language': 0,
-  \ 'project_root_callback': 'x',
+  \ 'project_root': 'x',
   \}
 
   AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual '`language` must be a String or Funcref', g:vader_exception
+  AssertEqual '`language` must be a String or Funcref if defined', g:vader_exception
 
 Execute(PreProcess should use the filetype as the language string by default):
   let g:linter = {
   \ 'name': 'x',
   \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
-  \ 'project_root_callback': 'x',
-  \}
-
-  AssertEqual 'testft', ale#linter#PreProcess('testft', g:linter).language_callback(0)
-
-Execute(PreProcess should allow language to be set to a callback):
-  let g:linter = {
-  \ 'name': 'x',
-  \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
-  \ 'language': {-> 'foo'},
-  \ 'project_root_callback': 'x',
+  \ 'address': 'X',
+  \ 'project_root': 'x',
   \}
 
-  AssertEqual 'foo', ale#linter#PreProcess('testft', g:linter).language_callback(0)
+  AssertEqual 'testft', ale#linter#PreProcess('testft', g:linter).language
 
-Execute(PreProcess should require an address_callback for LSP socket configurations):
+Execute(PreProcess should require an `address` for LSP socket configurations):
   let g:linter = {
   \ 'name': 'x',
   \ 'lsp': 'socket',
   \}
 
   AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual '`address` or `address_callback` must be defined for getting the LSP address', g:vader_exception
+  AssertEqual '`address` must be defined for getting the LSP address', g:vader_exception
 
-Execute(PreProcess should complain about address_callback for non-LSP linters):
+Execute(PreProcess should complain about `address` for non-LSP linters):
   let g:linter = {
   \ 'name': 'x',
   \ 'callback': 'SomeFunction',
   \ 'executable': 'echo',
   \ 'command': 'echo',
-  \ 'address_callback': 'X',
+  \ 'address': 'X',
   \}
 
   AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual '`address` or `address_callback` cannot be used when lsp != ''socket''', g:vader_exception
+  AssertEqual '`address` cannot be used when lsp != ''socket''', g:vader_exception
 
-Execute(PreProcess accept valid address_callback values):
-  let g:linter = ale#linter#PreProcess('testft', {
-  \ 'name': 'x',
-  \ 'lsp': 'socket',
-  \ 'address_callback': {-> 'foo:123'},
-  \ 'language': 'x',
-  \ 'project_root_callback': 'x',
-  \})
-
-  AssertEqual 'foo:123', ale#linter#GetAddress(0, g:linter)
-
-Execute(PreProcess accept address as a String):
+Execute(PreProcess accept `address` as a String):
   let g:linter = ale#linter#PreProcess('testft', {
   \ 'name': 'x',
   \ 'lsp': 'socket',
   \ 'address': 'foo:123',
   \ 'language': 'x',
-  \ 'project_root_callback': 'x',
+  \ 'project_root': 'x',
   \})
 
   AssertEqual 'foo:123', ale#linter#GetAddress(0, g:linter)
@@ -549,7 +352,7 @@ Execute(PreProcess accept address as a Function):
   \ 'lsp': 'socket',
   \ 'address': {-> 'foo:123'},
   \ 'language': 'x',
-  \ 'project_root_callback': 'x',
+  \ 'project_root': 'x',
   \})
 
   AssertEqual 'foo:123', ale#linter#GetAddress(0, g:linter)
@@ -560,11 +363,11 @@ Execute(PreProcess should complain about invalid address values):
   \ 'lsp': 'socket',
   \ 'address': 0,
   \ 'language': 'x',
-  \ 'project_root_callback': 'x',
+  \ 'project_root': 'x',
   \})
   AssertEqual '`address` must be a String or Function if defined', g:vader_exception
 
-Execute(PreProcess should accept allow the project root be set as a String):
+Execute(PreProcess should allow the `project_root` to be set as a String):
   let g:linter = ale#linter#PreProcess('testft', {
   \ 'name': 'x',
   \ 'lsp': 'socket',
@@ -575,7 +378,7 @@ Execute(PreProcess should accept allow the project root be set as a String):
 
   AssertEqual '/foo/bar', ale#lsp_linter#FindProjectRoot(0, g:linter)
 
-Execute(PreProcess should accept allow the project root be set as a Function):
+Execute(PreProcess should `project_root` be set as a Function):
   let g:linter = ale#linter#PreProcess('testft', {
   \ 'name': 'x',
   \ 'lsp': 'socket',
@@ -586,7 +389,7 @@ Execute(PreProcess should accept allow the project root be set as a Function):
 
   AssertEqual '/foo/bar', ale#lsp_linter#FindProjectRoot(0, g:linter)
 
-Execute(PreProcess should complain when the project_root valid is invalid):
+Execute(PreProcess should complain when `project_root` is invalid):
   AssertThrows call ale#linter#PreProcess('testft', {
   \ 'name': 'x',
   \ 'lsp': 'socket',
@@ -594,154 +397,74 @@ Execute(PreProcess should complain when the project_root valid is invalid):
   \ 'language': 'x',
   \ 'project_root': 0,
   \})
-  AssertEqual '`project_root` must be a String or Function if defined', g:vader_exception
+  AssertEqual '`project_root` must be a String or Function', g:vader_exception
 
-Execute(PreProcess should accept project_root_callback as a String):
-  call ale#linter#PreProcess('testft', {
-  \ 'name': 'x',
-  \ 'lsp': 'socket',
-  \ 'address': 'foo:123',
-  \ 'language': 'x',
-  \ 'project_root_callback': 'Foobar',
-  \})
-
-Execute(PreProcess should accept project_root_callback as a Function):
-  let g:linter = ale#linter#PreProcess('testft', {
-  \ 'name': 'x',
-  \ 'lsp': 'socket',
-  \ 'address': 'foo:123',
-  \ 'language': 'x',
-  \ 'project_root_callback': {-> '/foo/bar'},
-  \})
-
-  AssertEqual '/foo/bar', ale#lsp_linter#FindProjectRoot(0, g:linter)
-
-Execute(PreProcess should complain when the project_root_callback valid is invalid):
-  AssertThrows call ale#linter#PreProcess('testft', {
-  \ 'name': 'x',
-  \ 'lsp': 'socket',
-  \ 'address': 'foo:123',
-  \ 'language': 'x',
-  \ 'project_root_callback': 0,
-  \})
-  AssertEqual '`project_root_callback` must be a callback if defined', g:vader_exception
-
-Execute(PreProcess should complain about using initialization_options and initialization_options_callback together):
-  let g:linter = {
-  \ 'name': 'x',
-  \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
-  \ 'language': 'x',
-  \ 'project_root_callback': 'x',
-  \ 'initialization_options': 'x',
-  \ 'initialization_options_callback': 'x',
-  \}
-
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual 'Only one of `initialization_options` or `initialization_options_callback` should be set', g:vader_exception
-
-Execute(PreProcess should throw when initialization_options_callback is not a callback):
-  AssertThrows call ale#linter#PreProcess('testft', {
-  \ 'name': 'foo',
-  \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
-  \ 'language': 'x',
-  \ 'project_root_callback': 'x',
-  \ 'initialization_options_callback': {},
-  \})
-  AssertEqual '`initialization_options_callback` must be a callback if defined', g:vader_exception
-
-Execute(PreProcess should throw when initialization_options is not a Dictionary or callback):
+Execute(PreProcess should throw when `initialization_options` is not a Dictionary or callback):
   AssertThrows call ale#linter#PreProcess('testft', {
   \ 'name': 'foo',
   \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
+  \ 'address': 'X',
   \ 'language': 'x',
-  \ 'project_root_callback': 'x',
+  \ 'project_root': 'x',
   \ 'initialization_options': 0,
   \})
-  AssertEqual '`initialization_options` must be a String or Function if defined', g:vader_exception
+  AssertEqual '`initialization_options` must be a Dictionary or Function if defined', g:vader_exception
 
-Execute(PreProcess should accept initialization_options as a Dictionary):
+Execute(PreProcess should accept `initialization_options` as a Dictionary):
   let g:linter = ale#linter#PreProcess('testft', {
   \ 'name': 'foo',
   \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
+  \ 'address': 'X',
   \ 'language': 'x',
-  \ 'project_root_callback': 'x',
+  \ 'project_root': 'x',
   \ 'initialization_options': {'foo': v:true},
   \})
 
   AssertEqual {'foo': v:true}, ale#lsp_linter#GetOptions(0, g:linter)
 
-Execute(PreProcess should accept initialization_options as a Funcref):
+Execute(PreProcess should accept `initialization_options` as a Function):
   let g:linter = ale#linter#PreProcess('testft', {
   \ 'name': 'foo',
   \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
+  \ 'address': 'X',
   \ 'language': 'x',
-  \ 'project_root_callback': 'x',
+  \ 'project_root': 'x',
   \ 'initialization_options': {-> {'foo': v:true}},
   \})
 
   AssertEqual {'foo': v:true}, ale#lsp_linter#GetOptions(0, g:linter)
 
-Execute(PreProcess should complain about using lsp_config and lsp_config_callback together):
+Execute(PreProcess should accept `lsp_config` as a Dictionary):
   let g:linter = {
   \ 'name': 'x',
   \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
+  \ 'address': 'X',
   \ 'language': 'x',
-  \ 'project_root_callback': 'x',
-  \ 'lsp_config': 'x',
-  \ 'lsp_config_callback': 'x',
-  \}
-
-  AssertThrows call ale#linter#PreProcess('testft', g:linter)
-  AssertEqual 'Only one of `lsp_config` or `lsp_config_callback` should be set', g:vader_exception
-
-Execute(PreProcess should throw when lsp_config_callback is not a callback):
-  AssertThrows call ale#linter#PreProcess('testft', {
-  \ 'name': 'foo',
-  \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
-  \ 'language': 'x',
-  \ 'project_root_callback': 'x',
-  \ 'lsp_config_callback': {},
-  \})
-  AssertEqual '`lsp_config_callback` must be a callback if defined', g:vader_exception
-
-Execute(PreProcess should accept LSP configuration options via lsp_config):
-  let g:linter = {
-  \ 'name': 'x',
-  \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
-  \ 'language_callback': 'x',
-  \ 'project_root_callback': 'x',
+  \ 'project_root': 'x',
   \ 'lsp_config': {'foo': 'bar'},
   \}
 
   AssertEqual {'foo': 'bar'}, ale#lsp_linter#GetConfig(0, g:linter)
 
-Execute(PreProcess should accept LSP configuration options via lsp_config as a function):
+Execute(PreProcess should accept `lsp_config` as a Function):
   let g:linter = {
   \ 'name': 'x',
   \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
-  \ 'language_callback': 'x',
-  \ 'project_root_callback': 'x',
+  \ 'address': 'X',
+  \ 'language': 'x',
+  \ 'project_root': 'x',
   \ 'lsp_config': {-> {'foo': 'bar'}},
   \}
 
   AssertEqual {'foo': 'bar'}, ale#lsp_linter#GetConfig(0, g:linter)
 
-Execute(PreProcess should throw when lsp_config is not a Dictionary or Function):
+Execute(PreProcess should throw when `lsp_config` is not a Dictionary or Function):
   AssertThrows call ale#linter#PreProcess('testft', {
   \ 'name': 'foo',
   \ 'lsp': 'socket',
-  \ 'address_callback': 'X',
+  \ 'address': 'X',
   \ 'language': 'x',
-  \ 'project_root_callback': 'x',
+  \ 'project_root': 'x',
   \ 'lsp_config': 'x',
   \})
   AssertEqual '`lsp_config` must be a Dictionary or Function if defined', g:vader_exception