summaryrefslogtreecommitdiff
path: root/ale_linters/sh
diff options
context:
space:
mode:
authorAdriaan Zonnenberg <adriaanzon@users.noreply.github.com>2017-03-31 00:33:38 +0200
committerw0rp <w0rp@users.noreply.github.com>2017-03-30 23:33:38 +0100
commit4b0f3257ddf4303a00979cd1171dd449bd3b9ed5 (patch)
tree22e932441ca241313cc5a918d4c167e9e52f2032 /ale_linters/sh
parent6c97cd335b33d2160288b992602a0deda2ae5652 (diff)
downloadale-4b0f3257ddf4303a00979cd1171dd449bd3b9ed5.zip
Remove 'col' from linters where it is hardcoded to 1 (#434)
* Remove 'col' from linters where it is hardcoded to 1 When 'col' is 1, the first column will get highlighted for no reason. It should be 0 (which is the default). In the scalac linter there was also a check about the outcome of `stridx`. It would set l:col to 0 if it was -1, and then it uses `'col': l:col + 1` to convert the outcome of `stridx` to the actual column number. This will make 'col' equals 1 when there is no match. We can remove the check because `-1 + 1 = 0`. * Remove outdated comments about vcol vcol was added as a default, and the loclists that follow these comments do not contain 'vcol' anymore
Diffstat (limited to 'ale_linters/sh')
-rw-r--r--ale_linters/sh/shell.vim3
1 files changed, 0 insertions, 3 deletions
diff --git a/ale_linters/sh/shell.vim b/ale_linters/sh/shell.vim
index c7365ae9..7ab98fd6 100644
--- a/ale_linters/sh/shell.vim
+++ b/ale_linters/sh/shell.vim
@@ -49,15 +49,12 @@ function! ale_linters#sh#shell#Handle(buffer, lines) abort
endif
let l:line = l:match[1] + 0
- let l:column = 1
let l:text = l:match[2]
let l:type = 'E'
- " vcol is Needed to indicate that the column is a character.
call add(l:output, {
\ 'bufnr': a:buffer,
\ 'lnum': l:line,
- \ 'col': l:column,
\ 'text': l:text,
\ 'type': l:type,
\})