summaryrefslogtreecommitdiff
path: root/ale_linters/eruby
diff options
context:
space:
mode:
authorEddie Lebow <elebow@users.noreply.github.com>2017-11-11 21:59:18 -0500
committerEddie Lebow <elebow@users.noreply.github.com>2017-11-12 23:33:34 -0500
commitad7ea3630758af51f6be826fcd453dfc42a6cd75 (patch)
treeed1529fa1eed35d22ceb4c4bc77b68b922b00f3a /ale_linters/eruby
parentea7f68226ecdc0e6be3d6300c46bc8c88a00c756 (diff)
downloadale-ad7ea3630758af51f6be826fcd453dfc42a6cd75.zip
[eruby] Add GetCommand to erubis linter
GetCommand conditionally adds a filter (implemented as inline Ruby code in the command line) to transform some of the problematic Rails-specific eRuby syntax. Specifically, <%= tags are replaced with <%. This does not reduce the effectiveness of the linter, because the transformed code is still evaluated. This solution was suggested by @rgo at https://github.com/w0rp/ale/issues/580#issuecomment-337676607.
Diffstat (limited to 'ale_linters/eruby')
-rw-r--r--ale_linters/eruby/erubis.vim18
1 files changed, 15 insertions, 3 deletions
diff --git a/ale_linters/eruby/erubis.vim b/ale_linters/eruby/erubis.vim
index be9332df..ac356aeb 100644
--- a/ale_linters/eruby/erubis.vim
+++ b/ale_linters/eruby/erubis.vim
@@ -1,11 +1,23 @@
-" Author: Jake Zimmerman <jake@zimmerman.io>
+" Author: Jake Zimmerman <jake@zimmerman.io>, Eddie Lebow https://github.com/elebow
" Description: eruby checker using `erubis`, instead of `erb`
+function! ale_linters#eruby#erubis#GetCommand(buffer) abort
+ let l:rails_root = ale#ruby#FindRailsRoot(a:buffer)
+
+ if empty(l:rails_root)
+ return 'erubis -x %t | ruby -c'
+ endif
+
+ " Rails-flavored eRuby does not comply with the standard as understood by
+ " Erubis, so we'll have to do some substitution. This does not reduce the
+ " effectiveness of the linter—the translated code is still evaluated.
+ return 'ruby -r erubis -e ' . ale#Escape('puts Erubis::Eruby.new($stdin.read.gsub(%{<%=},%{<%})).src') . ' | ruby -c'
+endfunction
+
call ale#linter#Define('eruby', {
\ 'name': 'erubis',
\ 'executable': 'erubis',
\ 'output_stream': 'stderr',
-\ 'command': 'erubis -x %t | ruby -c',
+\ 'command_callback': 'ale_linters#eruby#erubis#GetCommand',
\ 'callback': 'ale#handlers#ruby#HandleSyntaxErrors',
\})
-