summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorw0rp <w0rp@users.noreply.github.com>2017-07-01 15:43:04 +0100
committerw0rp <devw0rp@gmail.com>2017-07-01 15:43:41 +0100
commit448600fe4fa5b011132b5c4484a854d5ea00bf3d (patch)
tree03b98b1901a6692e7b5552b7fb3d60f8bef43aa7
parentbb1f413bf36fc7f54f7828c5722f78df6a6169df (diff)
downloadale-448600fe4fa5b011132b5c4484a854d5ea00bf3d.zip
Merge pull request #716 from sobrinho/master
Fix brakeman handler when there is no output
-rw-r--r--ale_linters/ruby/brakeman.vim4
-rw-r--r--test/handler/test_brakeman_handler.vader6
2 files changed, 10 insertions, 0 deletions
diff --git a/ale_linters/ruby/brakeman.vim b/ale_linters/ruby/brakeman.vim
index fa5617df..5ea531f1 100644
--- a/ale_linters/ruby/brakeman.vim
+++ b/ale_linters/ruby/brakeman.vim
@@ -5,6 +5,10 @@ let g:ale_ruby_brakeman_options =
\ get(g:, 'ale_ruby_brakeman_options', '')
function! ale_linters#ruby#brakeman#Handle(buffer, lines) abort
+ if len(a:lines) == 0
+ return []
+ endif
+
let l:result = json_decode(join(a:lines, ''))
let l:output = []
diff --git a/test/handler/test_brakeman_handler.vader b/test/handler/test_brakeman_handler.vader
index bc7182e3..6a577beb 100644
--- a/test/handler/test_brakeman_handler.vader
+++ b/test/handler/test_brakeman_handler.vader
@@ -73,3 +73,9 @@ Execute(The brakeman handler should parse JSON correctly):
\ ']',
\ '}'
\ ])
+
+Execute(The brakeman handler should parse JSON correctly when there is no output from brakeman):
+ AssertEqual
+ \ [],
+ \ ale_linters#ruby#brakeman#Handle(347, [
+ \ ])