summaryrefslogtreecommitdiff
path: root/tests/unit
diff options
context:
space:
mode:
authorSébastien Helleu <flashcode@flashtux.org>2021-03-16 18:47:31 +0100
committerSébastien Helleu <flashcode@flashtux.org>2021-03-16 18:47:31 +0100
commit0dc7fbcb0ce6a13427c3c362d777554ec55ec74a (patch)
treefdee3f8c05be225d32d28db6597710c8acb3e09c /tests/unit
parentbb41de8c0255887720f570e5f0594a497f9ea0a0 (diff)
downloadweechat-0dc7fbcb0ce6a13427c3c362d777554ec55ec74a.zip
core: add options to customize commands on system signals, quit by default on SIGHUP when not running headless (closes #1595)
New options to customize behavior on signals received, with the default behavior: - weechat.signal.sighup: quit in normal mode, reload config in headless - weechat.signal.sigquit: quit - weechat.signal.sigterm: quit - weechat.signal.sigusr1: no command executed by default - weechat.signal.sigusr2: no command executed by default The signals SIGUSR1 and SIGUSR2 are introduced by this commit, so it's now possible to run commands when they are received. The SIGHUP signal makes now WeeChat quit, it was the behavior before version 2.9 of WeeChat (see commit de1e61f7cd50cbd1a99777fe6611642a51abf5f6).
Diffstat (limited to 'tests/unit')
-rw-r--r--tests/unit/core/test-core-signal.cpp161
-rw-r--r--tests/unit/core/test-core-util.cpp66
2 files changed, 161 insertions, 66 deletions
diff --git a/tests/unit/core/test-core-signal.cpp b/tests/unit/core/test-core-signal.cpp
new file mode 100644
index 000000000..9178588ba
--- /dev/null
+++ b/tests/unit/core/test-core-signal.cpp
@@ -0,0 +1,161 @@
+/*
+ * test-core-signal.cpp - test util functions
+ *
+ * Copyright (C) 2021 Sébastien Helleu <flashcode@flashtux.org>
+ *
+ * This file is part of WeeChat, the extensible chat client.
+ *
+ * WeeChat is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * WeeChat is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with WeeChat. If not, see <https://www.gnu.org/licenses/>.
+ */
+
+#include "CppUTest/TestHarness.h"
+
+extern "C"
+{
+#include <unistd.h>
+#include <stdio.h>
+#include <string.h>
+#include <signal.h>
+#include "tests/tests.h"
+#include "src/core/wee-signal.h"
+}
+
+TEST_GROUP(CoreSignal)
+{
+};
+
+/*
+ * Tests functions:
+ * signal_search_number
+ */
+
+TEST(CoreSignal, SearchNumber)
+{
+ int count, index;
+
+ /* make tests fail if the signal_list structure is changed */
+ for (count = 0; signal_list[count].name; count++)
+ {
+ }
+ LONGS_EQUAL(7, count);
+
+ POINTERS_EQUAL(-1, signal_search_number (-1));
+ POINTERS_EQUAL(-1, signal_search_number (999999999));
+
+ index = signal_search_number (SIGHUP);
+ LONGS_EQUAL(SIGHUP, signal_list[index].signal);
+ STRCMP_EQUAL("hup", signal_list[index].name);
+
+ index = signal_search_number (SIGINT);
+ LONGS_EQUAL(SIGINT, signal_list[index].signal);
+ STRCMP_EQUAL("int", signal_list[index].name);
+
+ index = signal_search_number (SIGQUIT);
+ LONGS_EQUAL(SIGQUIT, signal_list[index].signal);
+ STRCMP_EQUAL("quit", signal_list[index].name);
+
+ index = signal_search_number (SIGKILL);
+ LONGS_EQUAL(SIGKILL, signal_list[index].signal);
+ STRCMP_EQUAL("kill", signal_list[index].name);
+
+ index = signal_search_number (SIGTERM);
+ LONGS_EQUAL(SIGTERM, signal_list[index].signal);
+ STRCMP_EQUAL("term", signal_list[index].name);
+
+ index = signal_search_number (SIGUSR1);
+ LONGS_EQUAL(SIGUSR1, signal_list[index].signal);
+ STRCMP_EQUAL("usr1", signal_list[index].name);
+
+ index = signal_search_number (SIGUSR2);
+ LONGS_EQUAL(SIGUSR2, signal_list[index].signal);
+ STRCMP_EQUAL("usr2", signal_list[index].name);
+}
+
+/*
+ * Tests functions:
+ * signal_search_name
+ */
+
+TEST(CoreSignal, SearchName)
+{
+ LONGS_EQUAL(-1, signal_search_name (NULL));
+ LONGS_EQUAL(-1, signal_search_name (""));
+ LONGS_EQUAL(-1, signal_search_name ("signal_does_not_exist"));
+
+ LONGS_EQUAL(SIGHUP, signal_search_name ("hup"));
+ LONGS_EQUAL(SIGHUP, signal_search_name ("HUP"));
+ LONGS_EQUAL(SIGINT, signal_search_name ("int"));
+ LONGS_EQUAL(SIGINT, signal_search_name ("INT"));
+ LONGS_EQUAL(SIGQUIT, signal_search_name ("quit"));
+ LONGS_EQUAL(SIGQUIT, signal_search_name ("QUIT"));
+ LONGS_EQUAL(SIGKILL, signal_search_name ("kill"));
+ LONGS_EQUAL(SIGKILL, signal_search_name ("KILL"));
+ LONGS_EQUAL(SIGTERM, signal_search_name ("term"));
+ LONGS_EQUAL(SIGTERM, signal_search_name ("TERM"));
+ LONGS_EQUAL(SIGUSR1, signal_search_name ("usr1"));
+ LONGS_EQUAL(SIGUSR1, signal_search_name ("USR1"));
+ LONGS_EQUAL(SIGUSR2, signal_search_name ("usr2"));
+ LONGS_EQUAL(SIGUSR2, signal_search_name ("USR2"));
+}
+
+/*
+ * Tests functions:
+ * signal_catch
+ */
+
+TEST(CoreSignal, Catch)
+{
+ /* TODO: write tests */
+}
+
+/*
+ * Tests functions:
+ * signal_send_to_weechat
+ */
+
+TEST(CoreSignal, SentToWeechat)
+{
+ /* TODO: write tests */
+}
+
+/*
+ * Tests functions:
+ * signal_exec_command
+ */
+
+TEST(CoreSignal, ExecCommand)
+{
+ /* TODO: write tests */
+}
+
+/*
+ * Tests functions:
+ * signal_handle_number
+ */
+
+TEST(CoreSignal, HandleNumber)
+{
+ /* TODO: write tests */
+}
+
+
+/*
+ * Tests functions:
+ * signal_handle
+ */
+
+TEST(CoreSignal, Handle)
+{
+ /* TODO: write tests */
+}
diff --git a/tests/unit/core/test-core-util.cpp b/tests/unit/core/test-core-util.cpp
index 41308703d..e78d2ba77 100644
--- a/tests/unit/core/test-core-util.cpp
+++ b/tests/unit/core/test-core-util.cpp
@@ -26,7 +26,6 @@ extern "C"
#include <unistd.h>
#include <stdio.h>
#include <string.h>
-#include <signal.h>
#include <sys/time.h>
#include "src/core/wee-string.h"
#include "src/core/wee-util.h"
@@ -225,71 +224,6 @@ TEST(CoreUtil, ParseDelay)
/*
* Tests functions:
- * util_signal_search
- */
-
-TEST(CoreUtil, SignalSearch)
-{
- int count;
-
- /* make tests fail if the util_signals structure is changed */
- for (count = 0; util_signals[count].name; count++)
- {
- }
- LONGS_EQUAL(7, count);
-
- LONGS_EQUAL(-1, util_signal_search (NULL));
- LONGS_EQUAL(-1, util_signal_search (""));
- LONGS_EQUAL(-1, util_signal_search ("signal_does_not_exist"));
-
- LONGS_EQUAL(SIGHUP, util_signal_search ("hup"));
- LONGS_EQUAL(SIGINT, util_signal_search ("int"));
- LONGS_EQUAL(SIGQUIT, util_signal_search ("quit"));
- LONGS_EQUAL(SIGKILL, util_signal_search ("kill"));
- LONGS_EQUAL(SIGTERM, util_signal_search ("term"));
- LONGS_EQUAL(SIGUSR1, util_signal_search ("usr1"));
- LONGS_EQUAL(SIGUSR2, util_signal_search ("usr2"));
-
- LONGS_EQUAL(SIGHUP, util_signal_search ("HUP"));
- LONGS_EQUAL(SIGINT, util_signal_search ("INT"));
- LONGS_EQUAL(SIGQUIT, util_signal_search ("QUIT"));
- LONGS_EQUAL(SIGKILL, util_signal_search ("KILL"));
- LONGS_EQUAL(SIGTERM, util_signal_search ("TERM"));
- LONGS_EQUAL(SIGUSR1, util_signal_search ("USR1"));
- LONGS_EQUAL(SIGUSR2, util_signal_search ("USR2"));
-}
-
-/*
- * Tests functions:
- * util_signal_search_number
- */
-
-TEST(CoreUtil, SignalSearchNumber)
-{
- POINTERS_EQUAL(NULL, util_signal_search_number (-1));
- POINTERS_EQUAL(NULL, util_signal_search_number (999999999));
-
- STRCMP_EQUAL("hup", util_signal_search_number (SIGHUP));
- STRCMP_EQUAL("int", util_signal_search_number (SIGINT));
- STRCMP_EQUAL("quit", util_signal_search_number (SIGQUIT));
- STRCMP_EQUAL("kill", util_signal_search_number (SIGKILL));
- STRCMP_EQUAL("term", util_signal_search_number (SIGTERM));
- STRCMP_EQUAL("usr1", util_signal_search_number (SIGUSR1));
- STRCMP_EQUAL("usr2", util_signal_search_number (SIGUSR2));
-}
-
-/*
- * Tests functions:
- * util_catch_signal
- */
-
-TEST(CoreUtil, CatchSignal)
-{
- /* TODO: write tests */
-}
-
-/*
- * Tests functions:
* util_mkdir_home
* util_mkdir
* util_mkdir_parents