core: don't send key_combo_* signals for incomplete keys

Version 4.0.0 (specifically commit 1f5c791c3) changed the key handling
so key_combo_* signals were sent for each character in a sequence,
rather than just when the sequence is finished. This broke parts of the
vimode.py script.

E.g. for the up arrow, 3.8 sends key_combo_default signal once with the
signal_data `\x01[[A`, while 4.0.0 sends it three times with the
signal_data `\x01[`, `\x01[[` and `\x01[[A`.

With this patch, the previous behavior is brought back. There is one
small change though. In 3.8 if you press escape one or two times it
doesn't send key_combo_default, but if you press it three or more times
it sends it for each escape press. With this patch, it's never sent for
plain escape presses, only when the sequence is finished with some other
key.

This is intentional, as getting key_combo_default for escape presses
doesn't make sense since it's not a finished combo, and the behavior of
3.8 where you got it after three or more key presses was most likely
unintentional as it just happened because it didn't match any key
bindings anymore (there are key bindings starting with one or two escape
characters, but not more).

1 files changed, 5 insertions, 0 deletions

diff --git a/src/gui/gui-key.c b/src/gui/gui-key.c
index 19aa00f0f..ee43631ab 100644
--- a/src/gui/gui-key.c
+++ b/src/gui/gui-key.c
@@ -2388,6 +2388,11 @@ gui_key_pressed (const char *key_str)
 
     rc_expand = gui_key_expand (gui_key_combo, &key_name, &key_name_alias);
 
+    if (!rc_expand)
+    {
+        goto end_no_input;
+    }
+
     ptr_key = NULL;
     exact_match = 0;