summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSébastien Helleu <flashcode@flashtux.org>2023-05-21 22:14:55 +0200
committerSébastien Helleu <flashcode@flashtux.org>2023-05-23 21:49:53 +0200
commit3cb5f25681e9ecbfd21f9241f1f3ccd23efba3e7 (patch)
tree137cb9542385e3b031ea1c770ca0a0fd44f34022
parentf3e1da894b1e1c3a6ec729613bfa697f1a497ecb (diff)
downloadweechat-3cb5f25681e9ecbfd21f9241f1f3ccd23efba3e7.zip
irc: add missing tag "log3" in notify messages
-rw-r--r--ChangeLog.adoc1
-rw-r--r--src/plugins/irc/irc-notify.c3
-rw-r--r--tests/unit/plugins/irc/test-irc-protocol.cpp8
3 files changed, 7 insertions, 5 deletions
diff --git a/ChangeLog.adoc b/ChangeLog.adoc
index 14fe76e8f..0892851bc 100644
--- a/ChangeLog.adoc
+++ b/ChangeLog.adoc
@@ -86,6 +86,7 @@ Bug fixes::
* irc: fix target buffer for commands 432/433 (erroneous nickname/nickname already in use) when the nickname looks like a channel
* irc: display command 437 on server buffer when nickname cannot change while banned on channel (issue #88)
* irc: add messages 415 (cannot send message to channel) and 742 (mode cannot be set)
+ * irc: add missing tag "log3" in notify messages
* lua: fix crash with print when the value to print is not a string (issue #1904, issue #1905)
* ruby: fix crash on quit when a child process is still running (issue #1889, issue #1915)
* script: remove trailing "J" (line feed char) in source of scripts displayed
diff --git a/src/plugins/irc/irc-notify.c b/src/plugins/irc/irc-notify.c
index 6659a0b1b..86e828c9e 100644
--- a/src/plugins/irc/irc-notify.c
+++ b/src/plugins/irc/irc-notify.c
@@ -629,7 +629,8 @@ irc_notify_get_tags (struct t_config_option *option, const char *type,
tags = weechat_config_string (option);
- snprintf (string, sizeof (string), "irc_notify,irc_notify_%s,nick_%s%s%s",
+ snprintf (string, sizeof (string),
+ "irc_notify,irc_notify_%s,nick_%s%s%s,log3",
type,
nick,
(tags && tags[0]) ? "," : "",
diff --git a/tests/unit/plugins/irc/test-irc-protocol.cpp b/tests/unit/plugins/irc/test-irc-protocol.cpp
index 2112960d1..1b6eafdd8 100644
--- a/tests/unit/plugins/irc/test-irc-protocol.cpp
+++ b/tests/unit/plugins/irc/test-irc-protocol.cpp
@@ -5161,18 +5161,18 @@ TEST(IrcProtocolWithServer, 730)
run_cmd_quiet ("/notify add nick1 " IRC_FAKE_SERVER);
RECV(":server 730 alice :nick1!user1@host1,nick2!user2@host2");
CHECK_SRV("--", "notify: nick1 (user1@host1) is connected",
- "irc_notify,irc_notify_join,nick_nick1,notify_message");
+ "irc_notify,irc_notify_join,nick_nick1,notify_message,log3");
RECV(":server 731 alice :nick1!user1@host1,nick2!user2@host2");
CHECK_SRV("--", "notify: nick1 (user1@host1) has quit",
- "irc_notify,irc_notify_quit,nick_nick1,notify_message");
+ "irc_notify,irc_notify_quit,nick_nick1,notify_message,log3");
/* with notify on nick1 and nick2 */
run_cmd_quiet ("/notify add nick2 " IRC_FAKE_SERVER);
RECV(":server 730 alice :nick1!user1@host1,nick2!user2@host2");
CHECK_SRV("--", "notify: nick1 (user1@host1) has connected",
- "irc_notify,irc_notify_join,nick_nick1,notify_message");
+ "irc_notify,irc_notify_join,nick_nick1,notify_message,log3");
CHECK_SRV("--", "notify: nick2 (user2@host2) is connected",
- "irc_notify,irc_notify_join,nick_nick2,notify_message");
+ "irc_notify,irc_notify_join,nick_nick2,notify_message,log3");
run_cmd_quiet ("/mute /notify del nick1 " IRC_FAKE_SERVER);
run_cmd_quiet ("/mute /notify del nick2 " IRC_FAKE_SERVER);