1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
|
local lang = require 'language'
local DiagnosticSeverity = {
Error = 1,
Warning = 2,
Information = 3,
Hint = 4,
}
local function searchUnusedLocals(results, callback)
for _, var in ipairs(results.locals) do
if var.key == 'self'
or var.key == '_'
or var.key == '_ENV'
or var.key == ''
then
goto NEXT_VAR
end
for _, info in ipairs(var) do
if info.type == 'get' then
goto NEXT_VAR
end
if info.type == 'local' then
if info.source.start == 0 then
goto NEXT_VAR
end
end
end
callback(var.source.start, var.source.finish, var.key)
::NEXT_VAR::
end
end
local function searchUndefinedGlobal(results, callback)
local env = results.locals[1]
for index, field in pairs(env.value.child) do
if field.value.lib then
goto NEXT_VAR
end
if type(index) ~= 'string' then
goto NEXT_VAR
end
local lIndex = index:lower()
if lIndex == 'log' or lIndex == 'arg' or lIndex == '' then
goto NEXT_VAR
end
if not index:find '%l' then
goto NEXT_VAR
end
for _, info in ipairs(field) do
if info.type == 'set' then
goto NEXT_VAR
end
end
for _, info in ipairs(field) do
if info.type == 'get' then
callback(info.source.start, info.source.finish, tostring(index))
end
end
::NEXT_VAR::
end
end
local function searchUnusedLabel(results, callback)
for _, label in ipairs(results.labels) do
for _, info in ipairs(label) do
if info.type == 'goto' then
goto NEXT_LABEL
end
end
for _, info in ipairs(label) do
if info.type == 'set' then
callback(info.source.start, info.source.finish, label.key)
end
end
::NEXT_LABEL::
end
end
local function isContainPos(obj, start, finish)
if obj.start <= start and obj.finish + 1 >= finish then
return true
end
return false
end
local function isInString(vm, start, finish)
for _, source in ipairs(vm.results.strings) do
if isContainPos(source, start, finish) then
return true
end
end
return false
end
local function searchSpaces(vm, lines, callback)
for i = 1, #lines do
local line = lines:line(i)
if line:find '^[ \t]+$' then
local start, finish = lines:range(i)
if isInString(vm, start, finish) then
goto NEXT_LINE
end
callback(start, finish, lang.script.DIAG_LINE_ONLY_SPACE)
goto NEXT_LINE
end
local pos = line:find '[ \t]+$'
if pos then
local start, finish = lines:range(i)
start = start + pos - 1
if isInString(vm, start, finish) then
goto NEXT_LINE
end
callback(start, finish, lang.script.DIAG_LINE_POST_SPACE)
goto NEXT_LINE
end
::NEXT_LINE::
end
end
local function searchRedefinition(results, uri, callback)
local used = {}
for _, var in ipairs(results.locals) do
if var.key == '_'
or var.key == '_ENV'
or var.key == ''
then
goto NEXT_VAR
end
local shadow = var.shadow
if not shadow then
goto NEXT_VAR
end
if used[shadow] then
goto NEXT_VAR
end
used[shadow] = true
-- 如果多次重定义，则不再警告
if #shadow >= 4 then
goto NEXT_VAR
end
local related = {}
for i = 1, #shadow do
related[i] = {
start = shadow[i].source.start,
finish = shadow[i].source.finish,
uri = uri,
}
end
for i = 2, #shadow do
callback(shadow[i].source.start, shadow[i].source.finish, shadow[i].key, related)
end
::NEXT_VAR::
end
end
local function searchNewLineCall(results, lines, callback)
for _, call in ipairs(results.calls) do
if not call.nextObj then
goto NEXT_CALL
end
if not call.lastObj.start then
goto NEXT_CALL
end
local callline = lines:rowcol(call.args.start)
local lastline = lines:rowcol(call.lastObj.finish)
if callline > lastline then
callback(call.args.start, call.args.finish)
end
::NEXT_CALL::
end
end
local function searchRedundantParameters(results, callback)
for _, call in ipairs(results.calls) do
if not call.func.built then
goto NEXT_CALL
end
if call.func.hasDots then
goto NEXT_CALL
end
if not call.func.args then
return
end
local max = #call.func.args
local passed = #call.args
for i = max + 1, passed do
local source = call.args[i]
if source.start then
callback(source.start, source.finish, max, passed)
else
log.error('No start: ', table.dump(source))
end
end
::NEXT_CALL::
end
end
return function (vm, lines, uri)
local datas = {}
local results = vm.results
-- 未使用的局部变量
searchUnusedLocals(results, function (start, finish, key)
datas[#datas+1] = {
start = start,
finish = finish,
level = DiagnosticSeverity.Information,
message = lang.script('DIAG_UNUSED_LOCAL', key),
}
end)
-- 读取未定义全局变量
searchUndefinedGlobal(results, function (start, finish, key)
datas[#datas+1] = {
start = start,
finish = finish,
level = DiagnosticSeverity.Warning,
message = lang.script('DIAG_UNDEFINED_GLOBAL', key),
}
end)
-- 未使用的Label
searchUnusedLabel(results, function (start, finish, key)
datas[#datas+1] = {
start = start,
finish = finish,
level =DiagnosticSeverity.Information,
message = lang.script('DIAG_UNUSED_LABEL', key)
}
end)
-- 只有空格与制表符的行，以及后置空格
searchSpaces(vm, lines, function (start, finish, message)
datas[#datas+1] = {
start = start,
finish = finish,
level = DiagnosticSeverity.Information,
message = message,
}
end)
-- 重定义局部变量
searchRedefinition(results, uri, function (start, finish, key, related)
datas[#datas+1] = {
start = start,
finish = finish,
level = DiagnosticSeverity.Information,
message = lang.script('DIAG_REDEFINED_LOCAL', key),
related = related,
}
end)
-- 以括号开始的一行（可能被误解析为了上一行的call）
searchNewLineCall(results, lines, function (start, finish)
datas[#datas+1] = {
start = start,
finish = finish,
level = DiagnosticSeverity.Information,
message = lang.script.DIAG_PREVIOUS_CALL,
}
end)
-- 调用函数时的参数数量是否超过函数的接收数量
searchRedundantParameters(results, function (start, finish, max, passed)
datas[#datas+1] = {
start = start,
finish = finish,
level = DiagnosticSeverity.Warning,
message = lang.script('DIAG_OVER_MAX_ARGS', max, passed),
}
end)
return datas
end
|
