1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
|
local files = require 'files'
local guide = require 'core.guide'
local vm = require 'vm'
local lang = require 'language'
local define = require 'proto.define'
local await = require 'await'
local function countCallArgs(source)
local result = 0
if not source.args then
return 0
end
if source.node and source.node.type == 'getmethod' then
result = result + 1
end
result = result + #source.args
return result
end
local function countFuncArgs(source)
local result = 0
if source.parent and source.parent.type == 'setmethod' then
result = result + 1
end
if not source.args or #source.args == 0 then
return result
end
if source.args[#source.args].type == '...' then
return math.maxinteger
end
result = result + #source.args
return result
end
local function countOverLoadArgs(source, doc)
local result = 0
if source.parent and source.parent.type == 'setmethod' then
result = result + 1
end
local func = doc.overload
if not func.args or #func.args == 0 then
return result
end
if func.args[#func.args].type == '...' then
return math.maxinteger
end
result = result + #func.args
return result
end
local function getFuncArgs(func)
local funcArgs
local defs = vm.getDefs(func)
for _, def in ipairs(defs) do
if def.value then
def = def.value
end
if def.type == 'function' then
local args = countFuncArgs(def)
if not funcArgs or args > funcArgs then
funcArgs = args
end
if def.bindDocs then
for _, doc in ipairs(def.bindDocs) do
if doc.type == 'doc.overload' then
args = countOverLoadArgs(def, doc)
if not funcArgs or args > funcArgs then
funcArgs = args
end
end
end
end
end
end
return funcArgs
end
return function (uri, callback)
local ast = files.getAst(uri)
if not ast then
return
end
local cache = vm.getCache 'redundant-parameter'
guide.eachSourceType(ast.ast, 'call', function (source)
local callArgs = countCallArgs(source)
if callArgs == 0 then
return
end
local func = source.node
local funcArgs = cache[func]
if funcArgs == nil then
funcArgs = getFuncArgs(func) or false
local refs = vm.getRefs(func, 0)
for _, ref in ipairs(refs) do
cache[ref] = funcArgs
end
end
if not funcArgs then
return
end
local delta = callArgs - funcArgs
if delta <= 0 then
return
end
for i = #source.args - delta + 1, #source.args do
local arg = source.args[i]
if arg then
callback {
start = arg.start,
finish = arg.finish,
tags = { define.DiagnosticTag.Unnecessary },
message = lang.script('DIAG_OVER_MAX_ARGS', funcArgs, callArgs)
}
end
end
end)
end
|
