summaryrefslogtreecommitdiff
path: root/script
diff options
context:
space:
mode:
authorRebecca Turner <rbt@sent.as>2023-11-07 09:14:19 -0800
committerRebecca Turner <rbt@sent.as>2023-11-07 09:14:19 -0800
commit13a24eef2329cdc19008421666af51e50d6c0889 (patch)
treed6c12e2448be914962fbcb0351d92d94c56a1149 /script
parent5a763b0ceecc9a817c8ce534dc726f5f6f6e1ac9 (diff)
downloadlua-language-server-13a24eef2329cdc19008421666af51e50d6c0889.zip
Fix backwards compatability with `Lua.workspace.checkThirdParty`
I attempted to maintain backwards compatability in #2354 but didn't fully understand the config type system.
Diffstat (limited to 'script')
-rw-r--r--script/library.lua8
1 files changed, 6 insertions, 2 deletions
diff --git a/script/library.lua b/script/library.lua
index 4446797a..290b5b33 100644
--- a/script/library.lua
+++ b/script/library.lua
@@ -610,9 +610,13 @@ local function check3rd(uri)
end
local checkThirdParty = config.get(uri, 'Lua.workspace.checkThirdParty')
-- Backwards compatability: `checkThirdParty` used to be a boolean.
- if not checkThirdParty or checkThirdParty == 'Disable' then
+ -- Note: `checkThirdParty` is defined as a string, so if a boolean is
+ -- supplied, it's converted to a string by the `config.config` module.
+ -- Hence we check for the strings `'true'` and `'false`' here, rather than
+ -- the boolean literals.
+ if checkThirdParty == 'Disable' or checkThirdParty == 'false' then
return
- elseif checkThirdParty == true then
+ elseif checkThirdParty == 'true' then
checkThirdParty = 'Ask'
end
local scp = scope.getScope(uri)