| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Sometimes the docs are present but an empty string. Lets not add it
unless there's actually text to add. This presents the data a little
better to clients since clients don't get an empty MarkedString.
|
|
What
===
Support other locations for finding src.zip so that it is found it if
lives at either:
- JAVA_HOME/lib/src.zip
- JAVA_HOME/src.zip
Why
===
I've observed in testing that some installations of JVMs include src.zip
in the root, others in a lib/src.zip.
|
|
What
===
Display docs are plaintext in hover, instead of inside a GitHub markdown
fenced markdown code block.
Why
===
Hover text can be made up of multiple MarkedStrings where a MarkedString
is either plaintext, or a codeblock for a code language. Docs are
usually intended to be displayed as plaintext (in markdown), with the
code blocks included alongside it. The docs shouldn't be returned as one
of the code blocks.
Reference
===
https://microsoft.github.io/language-server-protocol/specification#textDocument_hover
|
|
What
===
Remove '.hover' from the language name on code hover so language is set
as `java` instead of `java.hover`.
Why
===
The intention of the language is to display it in GitHub's markdown
fenced code block format. The '.hover' is unnecessary noise as only the
'java' is required to correctly satisfy the syntax of the fenced code
block.
|
|
What
===
Remove src.zip and get it from the path pointed to by the JAVA_HOME
environment variable.
Why
===
When using this tool standalone the lib/src.zip file doesn't seem to be
packaged inside what is jlinked which causes exceptions on startup. It
also seems odd to package src.zip inside the tool when Java JDK
installations come with src, and in the event they don't (e.g. OpenJDK
on Debian) they can be easily installed using the distros built in
package manager.
As a side note the src.zip licensing is ambiguous to me and it's not
clear from any other documentation in this repository how it is being
licensed. I assume it is properly licensed to have been included, but
regardless removing any licensing ambiguity from the tool seems ideal
for those using it.
|
|
What
===
Respond to shutdown request with an empty result.
Why
===
The server does not respond to the shutdown request. Clients expect a
response to the shutdown request before they issue the exit request.
This is to give the server time to shutdown properly before the client
also shuts down. In clients that follow this pattern properly, e.g.
vim-lsc, it can cause vim to block and wait for a response until a
timeout occurs.
|
|
|
|
|
|
|
|
|
|
|
|
What
===
Add a script for linking for debian.
Why
===
The location of java home is different on mac and debian, and on debian
there is no java_home variable to select version 11 of java. The default
jdk installation on debian is currently version 11 and the script uses
that. In the event it is not installed mvn will error because the
JAVA_HOME is pointing to an invalid path. In the event multiple version
of java are installed version 11 will be used regardless of which is set
as the default.
The patch script has been updated to use the JAVA_HOME path explicitly
for each command to ensure it uses the correct version of java when
multiple versions are installed. This is consistent with the link
scripts.
|
|
What
===
Add installation instructions for vim using the vim plugin vim-lsc.
Why
===
This tool works great in vim but it isn't straight forward setting it
up. These instructions will help others get off the ground using this
tool with vim.
|
|
What
===
Add '--quiet' option for standalone usage. When provided the logger will
be turned off resulting in no information writing to stderr.
Why
===
When using standalone with IDEs like vim and plugins like vim-lsc the
stderr of the command will be outputted into the terminal. This tool is
pretty noisy and writes a lot of information which is great for
development of the tool but not when using it day-to-day.
|
|
issues on some systems
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
