summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRodrigo Rebello <rprebello@gmail.com>2015-10-28 13:38:21 -0200
committerRodrigo Rebello <rprebello@gmail.com>2015-10-28 14:58:49 -0200
commit06bf25bfbaaf33772e36317dba28ce5b6a301616 (patch)
tree53af2ee803fafe91c9b7efc08281504ae80c64d2
parent7ab38f29edb59941281723d7031d41d93fae06bd (diff)
downloadirssi-06bf25bfbaaf33772e36317dba28ce5b6a301616.zip
Fix quote around macro argument
In m4/curses.m4, line 134, the 5th argument passed to AC_NCURSES was surrounded by '"' instead of '[' and ']'. Because of that, the expansion of AC_NCURSES in that case would produce the following line inside the configure script (note the repeated double quotes): screen_manager=""ncurses on $withval/include"" That would cause the following error when configure was executed with the "--with-ncurses=dir" argument: ./configure: line 13468: on: command not found Although in the case above the error doesn't actually influence the build process ('screen_manager' isn't used anywhere in the script), trying to execute 'on' might be harmful if it corresponded to an existing command in the user's environment.
-rw-r--r--m4/curses.m42
1 files changed, 1 insertions, 1 deletions
diff --git a/m4/curses.m4 b/m4/curses.m4
index 82b110fe..41c0e6c8 100644
--- a/m4/curses.m4
+++ b/m4/curses.m4
@@ -131,7 +131,7 @@ AC_DEFUN([AC_CHECK_CURSES],[
if test x$withval = xno ; then
search_ncurses=false
elif test x$withval != xyes ; then
- AC_NCURSES($withval/include, ncurses.h, -L$withval/lib -lncurses, -I$withval/include, "ncurses on $withval/include")
+ AC_NCURSES($withval/include, ncurses.h, -L$withval/lib -lncurses, -I$withval/include, [ncurses on $withval/include])
fi
)