Avoid starting the notification thread twice

Starting the notification thread more than once can result in strange
behavior. For example, when launching external commands, only the most
recently started thread is stopped which results in the external
command's screen output being overwritten by the notification bar.

Currently, there are a couple of situations where the thread is started
twice. As a first countermeasure, explicitly check whether the thread is
already running (and terminate it) before starting a new one.

Signed-off-by: Lukas Fleischer <lfleischer@calcurse.org>

1 files changed, 3 insertions, 0 deletions

diff --git a/src/notify.c b/src/notify.c
index be88a31..3e14022 100644
--- a/src/notify.c
+++ b/src/notify.c
@@ -549,6 +549,9 @@ int notify_same_recur_item(struct recur_apoint *i)
 /* Launch the notify-bar main thread. */
 void notify_start_main_thread(void)
 {
+	/* Avoid starting the notification bar thread twice. */
+	notify_stop_main_thread();
+
 	pthread_create(&notify_t_main, NULL, notify_main_thread, NULL);
 	notify_check_next_app(0);
 }