diff options
author | Jon Parise <jon@indelible.org> | 2021-03-23 06:04:51 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-03-23 22:04:51 +0900 |
commit | eb0ebe622102cc6da3d7e943a3b739db7b6ed216 (patch) | |
tree | 886dd0321e4e95e7dbf73b468330b22393a5bce4 /rplugin/python3 | |
parent | cdac7a830e78b1a1d2b3e7da135f2d92669dc3e3 (diff) | |
download | ale-eb0ebe622102cc6da3d7e943a3b739db7b6ed216.zip |
Switch to using buildifier's -path option (#3640)
Buildifier offers a -path command line option:
> Buildifier's reformatting depends in part on the path to the file
> relative to the workspace directory. Normally buildifier deduces
> that path from the file names given, but the path can be given
> explicitly with the -path argument. This is especially useful when
> reformatting standard input, or in scripts that reformat a temporary
> copy of a file.
This lets us drop our `-type`-guessing logic.
For the moment, we rely on the buffer filename being "relative to the
workspace directory", which it generally is, but in a future change, we
should introduce logic that will locate the WORKSPACE file and adjusts
the filename relative to that directory. This could be complicated based
on the working directory in which `buildifier` is executed, so a little
more research is necessary to implement that logic correctly.
Diffstat (limited to 'rplugin/python3')
0 files changed, 0 insertions, 0 deletions