Fix #668 - Support eslint for TypeScript

2 files changed, 11 insertions, 85 deletions

diff --git a/ale_linters/javascript/eslint.vim b/ale_linters/javascript/eslint.vim
index 9f3bdcef..785b8bb6 100644
--- a/ale_linters/javascript/eslint.vim
+++ b/ale_linters/javascript/eslint.vim
@@ -1,92 +1,9 @@
 " Author: w0rp <devw0rp@gmail.com>
 " Description: eslint for JavaScript files
 
-let g:ale_javascript_eslint_options =
-\   get(g:, 'ale_javascript_eslint_options', '')
-
-function! ale_linters#javascript#eslint#GetCommand(buffer) abort
-    let l:executable = ale#handlers#eslint#GetExecutable(a:buffer)
-
-    if ale#Has('win32') && l:executable =~? 'eslint\.js$'
-        " For Windows, if we detect an eslint.js script, we need to execute
-        " it with node, or the file can be opened with a text editor.
-        let l:head = 'node ' . ale#Escape(l:executable)
-    else
-        let l:head = ale#Escape(l:executable)
-    endif
-
-    let l:options = ale#Var(a:buffer, 'javascript_eslint_options')
-
-    return l:head
-    \   . (!empty(l:options) ? ' ' . l:options : '')
-    \   . ' -f unix --stdin --stdin-filename %s'
-endfunction
-
-let s:col_end_patterns = [
-\   '\vParsing error: Unexpected token (.+) ',
-\   '\v''(.+)'' is not defined.',
-\   '\v%(Unexpected|Redundant use of) [''`](.+)[''`]',
-\   '\vUnexpected (console) statement',
-\]
-
-function! ale_linters#javascript#eslint#Handle(buffer, lines) abort
-    let l:config_error_pattern = '\v^ESLint couldn''t find a configuration file'
-    \   . '|^Cannot read config file'
-    \   . '|^.*Configuration for rule .* is invalid'
-
-    " Look for a message in the first few lines which indicates that
-    " a configuration file couldn't be found.
-    for l:line in a:lines[:10]
-        if len(matchlist(l:line, l:config_error_pattern)) > 0
-            return [{
-            \   'lnum': 1,
-            \   'text': 'eslint configuration error (type :ALEDetail for more information)',
-            \   'detail': join(a:lines, "\n"),
-            \}]
-        endif
-    endfor
-
-    " Matches patterns line the following:
-    "
-    " /path/to/some-filename.js:47:14: Missing trailing comma. [Warning/comma-dangle]
-    " /path/to/some-filename.js:56:41: Missing semicolon. [Error/semi]
-    let l:pattern = '^.*:\(\d\+\):\(\d\+\): \(.\+\) \[\(.\+\)\]$'
-    " This second pattern matches lines like the following:
-    "
-    " /path/to/some-filename.js:13:3: Parsing error: Unexpected token
-    let l:parsing_pattern = '^.*:\(\d\+\):\(\d\+\): \(.\+\)$'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, [l:pattern, l:parsing_pattern])
-        let l:type = 'Error'
-        let l:text = l:match[3]
-
-        " Take the error type from the output if available.
-        if !empty(l:match[4])
-            let l:type = split(l:match[4], '/')[0]
-            let l:text .= ' [' . l:match[4] . ']'
-        endif
-
-        let l:obj = {
-        \   'lnum': l:match[1] + 0,
-        \   'col': l:match[2] + 0,
-        \   'text': l:text,
-        \   'type': l:type ==# 'Warning' ? 'W' : 'E',
-        \}
-
-        for l:col_match in ale#util#GetMatches(l:text, s:col_end_patterns)
-            let l:obj.end_col = l:obj.col + len(l:col_match[1]) - 1
-        endfor
-
-        call add(l:output, l:obj)
-    endfor
-
-    return l:output
-endfunction
-
 call ale#linter#Define('javascript', {
 \   'name': 'eslint',
 \   'executable_callback': 'ale#handlers#eslint#GetExecutable',
-\   'command_callback': 'ale_linters#javascript#eslint#GetCommand',
-\   'callback': 'ale_linters#javascript#eslint#Handle',
+\   'command_callback': 'ale#handlers#eslint#GetCommand',
+\   'callback': 'ale#handlers#eslint#Handle',
 \})
diff --git a/ale_linters/typescript/eslint.vim b/ale_linters/typescript/eslint.vim
new file mode 100644
index 00000000..f1ae54e7
--- /dev/null
+++ b/ale_linters/typescript/eslint.vim
@@ -0,0 +1,9 @@
+" Author: w0rp <devw0rp@gmail.com>
+" Description: eslint for JavaScript files
+
+call ale#linter#Define('typescript', {
+\   'name': 'eslint',
+\   'executable_callback': 'ale#handlers#eslint#GetExecutable',
+\   'command_callback': 'ale#handlers#eslint#GetCommand',
+\   'callback': 'ale#handlers#eslint#Handle',
+\})