diff options
| author | Bjorn Neergaard <bjorn@neersighted.com> | 2016-10-10 13:51:29 -0500 |
|---|---|---|
| committer | w0rp <w0rp@users.noreply.github.com> | 2016-10-10 19:51:29 +0100 |
| commit | 7f0ce89d2b574fd5bdd0c050eaad92deeb63086d (patch) | |
| tree | c508480ff3ccbf36ef7283610fdcaefe476ae6e1 /ale_linters/php | |
| parent | 0680f875fe9ef07daceb3e9a90224bee613730df (diff) | |
| download | ale-7f0ce89d2b574fd5bdd0c050eaad92deeb63086d.zip | |
First pass at optimizing ale to autoload (#80)
* First pass at optimizing ale to autoload
First off, the structure/function names should be revised a bit,
but I will wait for @w0rp's input before unifying the naming style.
Second off, the docs probably need some more work, I just did some
simple find-and-replace work.
With that said, this pull brings major performance gains for ale. On my
slowest system, fully loading ale and all its code takes around 150ms.
I have moved all of ale's autoload-able code to autoload/, and in
addition, implemented lazy-loading of linters. This brings load time on
that same system down to 5ms.
The only downside of lazy loading is that `g:ale_linters` cannot be
changed at runtime; however, it also speeds up performance at runtime by
simplfying the logic greatly.
Please let me know what you think!
Closes #59
* Address Travis/Vint errors
For some reason, ale isn't running vint for me...
* Incorporate feedback, make fixes
Lazy-loading logic is much improved.
* Add header comments; remove incorrect workaround
* Remove unneeded plugin guards
* Fix lazy-loading linter logic
Set the wrong variable....
* Fix capitialization
Diffstat (limited to 'ale_linters/php')
| -rw-r--r-- | ale_linters/php/php.vim | 2 | ||||
| -rw-r--r-- | ale_linters/php/phpcs.vim | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/ale_linters/php/php.vim b/ale_linters/php/php.vim index 808a5ce6..57519a24 100644 --- a/ale_linters/php/php.vim +++ b/ale_linters/php/php.vim @@ -36,7 +36,7 @@ function! ale_linters#php#php#Handle(buffer, lines) return output endfunction -call ALEAddLinter('php', { +call ale#linter#Define('php', { \ 'name': 'php', \ 'executable': 'php', \ 'output_stream': 'both', diff --git a/ale_linters/php/phpcs.vim b/ale_linters/php/phpcs.vim index db7598fa..ed74b443 100644 --- a/ale_linters/php/phpcs.vim +++ b/ale_linters/php/phpcs.vim @@ -50,7 +50,7 @@ function! ale_linters#php#phpcs#Handle(buffer, lines) return output endfunction -call ALEAddLinter('php', { +call ale#linter#Define('php', { \ 'name': 'phpcs', \ 'executable': 'phpcs', \ 'command_callback': 'ale_linters#php#phpcs#GetCommand', |