summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorw0rp <devw0rp@gmail.com>2017-06-06 20:37:04 +0100
committerw0rp <devw0rp@gmail.com>2017-06-06 20:40:07 +0100
commiteeea72e16740bb1dfa5bd554a927e6bbee76a9b5 (patch)
tree69cf426eb9fe7a16f4f75455f7ac398c5b716d75
parent7db805b0cd1367ebf866e0c149fd819e425f6e0d (diff)
downloadale-eeea72e16740bb1dfa5bd554a927e6bbee76a9b5.zip
Fix #625 Ignore Perl errors from other files
-rw-r--r--ale_linters/perl/perl.vim14
-rw-r--r--test/handler/test_perl_handler.vader25
2 files changed, 34 insertions, 5 deletions
diff --git a/ale_linters/perl/perl.vim b/ale_linters/perl/perl.vim
index ab4defbc..53c91d36 100644
--- a/ale_linters/perl/perl.vim
+++ b/ale_linters/perl/perl.vim
@@ -20,17 +20,21 @@ endfunction
function! ale_linters#perl#perl#Handle(buffer, lines) abort
let l:pattern = '\(.\+\) at \(.\+\) line \(\d\+\)'
let l:output = []
+ let l:basename = expand('#' . a:buffer . ':t')
for l:match in ale#util#GetMatches(a:lines, l:pattern)
let l:line = l:match[3]
let l:text = l:match[1]
let l:type = 'E'
- call add(l:output, {
- \ 'lnum': l:line,
- \ 'text': l:text,
- \ 'type': l:type,
- \})
+ if l:match[2][-len(l:basename):] ==# l:basename
+ \&& l:text !=# 'BEGIN failed--compilation aborted'
+ call add(l:output, {
+ \ 'lnum': l:line,
+ \ 'text': l:text,
+ \ 'type': l:type,
+ \})
+ endif
endfor
return l:output
diff --git a/test/handler/test_perl_handler.vader b/test/handler/test_perl_handler.vader
new file mode 100644
index 00000000..2961b266
--- /dev/null
+++ b/test/handler/test_perl_handler.vader
@@ -0,0 +1,25 @@
+Before:
+ " Switch to the test rails directory.
+ let b:path = getcwd()
+ silent! cd /testplugin/test/handler
+
+ runtime ale_linters/perl/perl.vim
+
+After:
+ silent! 'cd ' . fnameescape(b:path)
+ unlet! b:path
+
+ call ale#linter#Reset()
+
+Execute(The Perl linter should ignore errors from other files):
+ silent! noautocmd file bar.pl
+
+ AssertEqual
+ \ [
+ \ {'lnum': '2', 'type': 'E', 'text': 'Compilation failed in require'},
+ \ ],
+ \ ale_linters#perl#perl#Handle(bufnr(''), [
+ \ 'syntax error at ' . b:path . '/foo.pm line 4, near "aklsdfjmy "',
+ \ 'Compilation failed in require at ' . b:path . '/bar.pl line 2.',
+ \ 'BEGIN failed--compilation aborted at ' . b:path . '/bar.pl line 2.',
+ \ ])