diff options
| author | Eddie Lebow <elebow@users.github.com> | 2017-11-11 15:15:19 -0500 |
|---|---|---|
| committer | Eddie Lebow <elebow@users.github.com> | 2017-11-11 17:46:21 -0500 |
| commit | 4d44996af618bf3907370e45a1e875e3802398d0 (patch) | |
| tree | e7e7278ff8d3c709addca18549d519b3ff368a4d | |
| parent | 9e7c493e7e6a5b7d22502aebda399e93d40a7974 (diff) | |
| download | ale-4d44996af618bf3907370e45a1e875e3802398d0.zip | |
perlcritic: all issues are warnings
Perlcritic is a style checker, not a syntax validator.
This change was originally proposed by @RsrchBoy in
https://github.com/w0rp/ale/pull/784.
| -rw-r--r-- | ale_linters/perl/perlcritic.vim | 1 | ||||
| -rw-r--r-- | test/handler/test_perlcritic_handler.vader | 20 |
2 files changed, 21 insertions, 0 deletions
diff --git a/ale_linters/perl/perlcritic.vim b/ale_linters/perl/perlcritic.vim index df2f8b23..24f7eb86 100644 --- a/ale_linters/perl/perlcritic.vim +++ b/ale_linters/perl/perlcritic.vim @@ -61,6 +61,7 @@ function! ale_linters#perl#perlcritic#Handle(buffer, lines) abort \ 'lnum': l:match[1], \ 'col': l:match[2], \ 'text': l:match[3], + \ 'type': 'W' \}) endfor diff --git a/test/handler/test_perlcritic_handler.vader b/test/handler/test_perlcritic_handler.vader new file mode 100644 index 00000000..f00b07da --- /dev/null +++ b/test/handler/test_perlcritic_handler.vader @@ -0,0 +1,20 @@ +Before: + runtime ale_linters/perl/perlcritic.vim + +After: + call ale#linter#Reset() + +Execute(The Perl::Critic handler should create all issues as warnings): + AssertEqual + \ [ + \ { + \ 'lnum': '21', + \ 'col': '17', + \ 'text': 'Regular expression without "/m" flag', + \ 'type': 'W', + \ } + \ ], + \ ale_linters#perl#perlcritic#Handle(99, [ + \ '21:17 Regular expression without "/m" flag' + \ ]) + |