diff options
| author | David Hotham <david.hotham@metaswitch.com> | 2021-05-25 01:41:14 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-25 09:41:14 +0900 |
| commit | 3f386ae5e988d6e1b39332a760f9e990d2df7f31 (patch) | |
| tree | 26fa17bc98ea29922f96df1fc13bb04d42e7c2f4 | |
| parent | bf1c30f585fe4ff68596d93230964b862e8d5940 (diff) | |
| download | ale-3f386ae5e988d6e1b39332a760f9e990d2df7f31.zip | |
Don't use a temporary file for tflint (#3717)
* Don't use a temporary file for tflint
* set cwd for tflint
| -rw-r--r-- | ale_linters/terraform/tflint.vim | 3 | ||||
| -rw-r--r-- | test/linter/test_terraform_tflint.vader | 8 |
2 files changed, 6 insertions, 5 deletions
diff --git a/ale_linters/terraform/tflint.vim b/ale_linters/terraform/tflint.vim index f57ee6b6..86b5b74a 100644 --- a/ale_linters/terraform/tflint.vim +++ b/ale_linters/terraform/tflint.vim @@ -91,7 +91,7 @@ function! ale_linters#terraform#tflint#GetCommand(buffer) abort let l:cmd .= ' ' . l:opts endif - let l:cmd .= ' -f json %t' + let l:cmd .= ' -f json' return l:cmd endfunction @@ -99,6 +99,7 @@ endfunction call ale#linter#Define('terraform', { \ 'name': 'tflint', \ 'executable': {b -> ale#Var(b, 'terraform_tflint_executable')}, +\ 'cwd': '%s:h', \ 'command': function('ale_linters#terraform#tflint#GetCommand'), \ 'callback': 'ale_linters#terraform#tflint#Handle', \}) diff --git a/test/linter/test_terraform_tflint.vader b/test/linter/test_terraform_tflint.vader index 96811e81..b1963a77 100644 --- a/test/linter/test_terraform_tflint.vader +++ b/test/linter/test_terraform_tflint.vader @@ -5,18 +5,18 @@ After: call ale#assert#TearDownLinterTest() Execute(The default command should be correct): - AssertLinter 'tflint', ale#Escape('tflint') . ' -f json %t' + AssertLinter 'tflint', ale#Escape('tflint') . ' -f json' Execute(The default executable should be configurable): let b:ale_terraform_tflint_executable = 'asdf' - AssertLinter 'asdf', ale#Escape('asdf') . ' -f json %t' + AssertLinter 'asdf', ale#Escape('asdf') . ' -f json' Execute(Overriding options should work): let g:ale_terraform_tflint_executable = 'fnord' let g:ale_terraform_tflint_options = '--whatever' - AssertLinter 'fnord', ale#Escape('fnord') . ' --whatever -f json %t' + AssertLinter 'fnord', ale#Escape('fnord') . ' --whatever -f json' Execute(Configuration files should be found): call ale#test#SetFilename('../test-files/tflint/foo/bar.tf') @@ -25,4 +25,4 @@ Execute(Configuration files should be found): \ ale#Escape('tflint') \ . ' --config ' \ . ale#Escape(ale#path#Simplify(g:dir . '/../test-files/tflint/foo/.tflint.hcl')) - \ . ' -f json %t' + \ . ' -f json' |