Merge pull request #1696 from mfietz/issue/1695-npe-context-null

Ensure initialization

5 files changed, 128 insertions, 7 deletions

diff --git a/core/src/main/java/de/danoeh/antennapod/core/ClientConfig.java b/core/src/main/java/de/danoeh/antennapod/core/ClientConfig.java
index 6619e706b..a96affb23 100644
--- a/core/src/main/java/de/danoeh/antennapod/core/ClientConfig.java
+++ b/core/src/main/java/de/danoeh/antennapod/core/ClientConfig.java
@@ -1,5 +1,12 @@
 package de.danoeh.antennapod.core;
 
+import android.content.Context;
+
+import de.danoeh.antennapod.core.preferences.PlaybackPreferences;
+import de.danoeh.antennapod.core.preferences.UserPreferences;
+import de.danoeh.antennapod.core.storage.PodDBAdapter;
+import de.danoeh.antennapod.core.util.NetworkUtils;
+
 /**
  * Stores callbacks for core classes like Services, DB classes etc. and other configuration variables.
  * Apps using the core module of AntennaPod should register implementations of all interfaces here.
@@ -22,4 +29,19 @@ public class ClientConfig {
     public static FlattrCallbacks flattrCallbacks;
 
     public static DBTasksCallbacks dbTasksCallbacks;
+
+    private static boolean initialized = false;
+
+    public static synchronized void initialize(Context context) {
+        if(initialized) {
+            return;
+        }
+        PodDBAdapter.init(context);
+        UserPreferences.init(context);
+        UpdateManager.init(context);
+        PlaybackPreferences.init(context);
+        NetworkUtils.init(context);
+        initialized = true;
+    }
+
 }
diff --git a/core/src/main/java/de/danoeh/antennapod/core/UpdateManager.java b/core/src/main/java/de/danoeh/antennapod/core/UpdateManager.java
new file mode 100644
index 000000000..8362c4a4e
--- /dev/null
+++ b/core/src/main/java/de/danoeh/antennapod/core/UpdateManager.java
@@ -0,0 +1,97 @@
+package de.danoeh.antennapod.core;
+
+
+import android.content.Context;
+import android.content.SharedPreferences;
+import android.content.pm.PackageInfo;
+import android.content.pm.PackageManager;
+import android.os.Build;
+import android.util.Log;
+
+import org.antennapod.audio.MediaPlayer;
+
+import java.io.File;
+import java.util.List;
+
+import de.danoeh.antennapod.core.feed.Feed;
+import de.danoeh.antennapod.core.feed.FeedImage;
+import de.danoeh.antennapod.core.feed.FeedItem;
+import de.danoeh.antennapod.core.preferences.UserPreferences;
+import de.danoeh.antennapod.core.storage.DBReader;
+import de.danoeh.antennapod.core.storage.DBWriter;
+
+/*
+ * This class's job is do perform maintenance tasks whenever the app has been updated
+ */
+public class UpdateManager {
+
+    public static final String TAG = UpdateManager.class.getSimpleName();
+
+    private static final String PREF_NAME = "app_version";
+    private static final String KEY_VERSION_CODE = "version_code";
+
+    private static int currentVersionCode;
+
+    private static Context context;
+    private static SharedPreferences prefs;
+
+    public static void init(Context context) {
+        UpdateManager.context = context;
+        prefs = context.getSharedPreferences(PREF_NAME, Context.MODE_PRIVATE);
+        PackageManager pm = context.getPackageManager();
+        try {
+            PackageInfo info = pm.getPackageInfo(context.getPackageName(), 0);
+            currentVersionCode = info.versionCode;
+        } catch (PackageManager.NameNotFoundException e) {
+            Log.e(TAG, "Failed to obtain package info for package name: " + context.getPackageName(), e);
+            currentVersionCode = 0;
+            return;
+        }
+        final int oldVersionCode = getStoredVersionCode();
+        Log.d(TAG, "old: " + oldVersionCode + ", current: " + currentVersionCode);
+        if(oldVersionCode < currentVersionCode) {
+            onUpgrade(oldVersionCode, currentVersionCode);
+            setCurrentVersionCode();
+        }
+    }
+
+    public static int getStoredVersionCode() {
+        return prefs.getInt(KEY_VERSION_CODE, -1);
+    }
+
+    public static void setCurrentVersionCode() {
+        prefs.edit().putInt(KEY_VERSION_CODE, currentVersionCode).apply();
+    }
+
+    private static void onUpgrade(final int oldVersionCode, final int newVersionCode) {
+        if(oldVersionCode < 1030099) {
+            // delete the now obsolete image cache
+            // from now on, Glide will handle caching images
+            new Thread() {
+                public void run() {
+                    List<Feed> feeds = DBReader.getFeedList();
+                    for (Feed podcast : feeds) {
+                        List<FeedItem> episodes = DBReader.getFeedItemList(podcast);
+                        for (FeedItem episode : episodes) {
+                            FeedImage image = episode.getImage();
+                            if (image != null && image.isDownloaded() && image.getFile_url() != null) {
+                                File imageFile = new File(image.getFile_url());
+                                if (imageFile.exists()) {
+                                    imageFile.delete();
+                                }
+                                image.setFile_url(null); // calls setDownloaded(false)
+                                DBWriter.setFeedImage(image);
+                            }
+                        }
+                    }
+                }
+            }.start();
+        }
+        if(oldVersionCode < 1050004) {
+            if(MediaPlayer.isPrestoLibraryInstalled(context) && Build.VERSION.SDK_INT >= 16) {
+                UserPreferences.enableSonic(true);
+            }
+        }
+    }
+
+}
diff --git a/core/src/main/java/de/danoeh/antennapod/core/receiver/AlarmUpdateReceiver.java b/core/src/main/java/de/danoeh/antennapod/core/receiver/AlarmUpdateReceiver.java
index ce5004a98..33c15883b 100644
--- a/core/src/main/java/de/danoeh/antennapod/core/receiver/AlarmUpdateReceiver.java
+++ b/core/src/main/java/de/danoeh/antennapod/core/receiver/AlarmUpdateReceiver.java
@@ -6,7 +6,7 @@ import android.content.Intent;
 import android.text.TextUtils;
 import android.util.Log;
 
-import de.danoeh.antennapod.core.preferences.PlaybackPreferences;
+import de.danoeh.antennapod.core.ClientConfig;
 import de.danoeh.antennapod.core.preferences.UserPreferences;
 
 /** Listens for events that make it necessary to reset the update alarm. */
@@ -22,8 +22,7 @@ public class AlarmUpdateReceiver extends BroadcastReceiver {
 		} else if (TextUtils.equals(intent.getAction(), Intent.ACTION_PACKAGE_REPLACED)) {
 			Log.d(TAG, "Resetting update alarm after app upgrade");
 		}
-        PlaybackPreferences.init(context);
-        UserPreferences.init(context);
+		ClientConfig.initialize(context);
         UserPreferences.restartUpdateAlarm(false);
 	}
 
diff --git a/core/src/main/java/de/danoeh/antennapod/core/receiver/FeedUpdateReceiver.java b/core/src/main/java/de/danoeh/antennapod/core/receiver/FeedUpdateReceiver.java
index b959c7301..e0abe0efb 100644
--- a/core/src/main/java/de/danoeh/antennapod/core/receiver/FeedUpdateReceiver.java
+++ b/core/src/main/java/de/danoeh/antennapod/core/receiver/FeedUpdateReceiver.java
@@ -5,6 +5,7 @@ import android.content.Context;
 import android.content.Intent;
 import android.util.Log;
 
+import de.danoeh.antennapod.core.ClientConfig;
 import de.danoeh.antennapod.core.preferences.UserPreferences;
 import de.danoeh.antennapod.core.storage.DBTasks;
 import de.danoeh.antennapod.core.util.NetworkUtils;
@@ -19,6 +20,7 @@ public class FeedUpdateReceiver extends BroadcastReceiver {
     @Override
     public void onReceive(Context context, Intent intent) {
         Log.d(TAG, "Received intent");
+        ClientConfig.initialize(context);
         if (NetworkUtils.isDownloadAllowed()) {
             DBTasks.refreshAllFeeds(context, null);
         } else {
diff --git a/core/src/main/java/de/danoeh/antennapod/core/receiver/MediaButtonReceiver.java b/core/src/main/java/de/danoeh/antennapod/core/receiver/MediaButtonReceiver.java
index a900248d2..51cc52e10 100644
--- a/core/src/main/java/de/danoeh/antennapod/core/receiver/MediaButtonReceiver.java
+++ b/core/src/main/java/de/danoeh/antennapod/core/receiver/MediaButtonReceiver.java
@@ -5,7 +5,8 @@ import android.content.Context;
 import android.content.Intent;
 import android.util.Log;
 import android.view.KeyEvent;
-import de.danoeh.antennapod.core.BuildConfig;
+
+import de.danoeh.antennapod.core.ClientConfig;
 import de.danoeh.antennapod.core.service.playback.PlaybackService;
 
 /** Receives media button events. */
@@ -17,10 +18,10 @@ public class MediaButtonReceiver extends BroadcastReceiver {
 
 	@Override
 	public void onReceive(Context context, Intent intent) {
-		if (BuildConfig.DEBUG) Log.d(TAG, "Received intent");
-		KeyEvent event = (KeyEvent) intent.getExtras().get(
-				Intent.EXTRA_KEY_EVENT);
+		Log.d(TAG, "Received intent");
+		KeyEvent event = (KeyEvent) intent.getExtras().get(Intent.EXTRA_KEY_EVENT);
 		if (event.getAction() == KeyEvent.ACTION_DOWN) {
+			ClientConfig.initialize(context);
 			Intent serviceIntent = new Intent(context, PlaybackService.class);
 			int keycode = event.getKeyCode();
 			serviceIntent.putExtra(EXTRA_KEYCODE, keycode);