diff options
author | orionlee <orionlee@yahoo.com> | 2018-05-18 13:42:39 -0700 |
---|---|---|
committer | orionlee <orionlee@yahoo.com> | 2018-05-18 13:42:39 -0700 |
commit | eb0ef1e2014c8e1b8f7ff76359bd476cc52fd7b5 (patch) | |
tree | 0ef0fe3b746db7d7a6271307fed1e4006f7c4c41 /core/src | |
parent | 46ae3e0b00a3b3ec8ef7ba01efad8bcfb1a79398 (diff) | |
download | AntennaPod-eb0ef1e2014c8e1b8f7ff76359bd476cc52fd7b5.zip |
core tests: Make DownloadServiceTest be a unit test (the portion of
DownloadService tested is all in-memory logic).
Diffstat (limited to 'core/src')
-rw-r--r-- | core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java | 4 | ||||
-rw-r--r-- | core/src/test/java/de/danoeh/antennapod/core/service/download/DownloadServiceTest.java (renamed from core/src/androidTest/java/de/danoeh/antennapod/core/service/download/DownloadServiceTest.java) | 8 |
2 files changed, 7 insertions, 5 deletions
diff --git a/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java b/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java index a62c9d8bf..ae103ee18 100644 --- a/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java +++ b/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java @@ -7,8 +7,6 @@ import android.content.BroadcastReceiver; import android.content.Context; import android.content.Intent; import android.content.IntentFilter; -import android.graphics.Bitmap; -import android.graphics.BitmapFactory; import android.media.MediaMetadataRetriever; import android.os.Binder; import android.os.Build; @@ -1107,7 +1105,7 @@ public class DownloadService extends Service { * that every image reference is unique. */ @VisibleForTesting - public static void removeDuplicateImages(Feed feed) { + static void removeDuplicateImages(Feed feed) { Set<String> known = new HashSet<>(); for (FeedItem item : feed.getItems()) { String url = item.hasItemImage() ? item.getImage().getDownload_url() : null; diff --git a/core/src/androidTest/java/de/danoeh/antennapod/core/service/download/DownloadServiceTest.java b/core/src/test/java/de/danoeh/antennapod/core/service/download/DownloadServiceTest.java index ee27f6bbd..e40de2064 100644 --- a/core/src/androidTest/java/de/danoeh/antennapod/core/service/download/DownloadServiceTest.java +++ b/core/src/test/java/de/danoeh/antennapod/core/service/download/DownloadServiceTest.java @@ -1,6 +1,7 @@ package de.danoeh.antennapod.core.service.download; -import android.test.AndroidTestCase; + +import org.junit.Test; import java.util.ArrayList; import java.util.List; @@ -9,8 +10,11 @@ import de.danoeh.antennapod.core.feed.Feed; import de.danoeh.antennapod.core.feed.FeedImage; import de.danoeh.antennapod.core.feed.FeedItem; -public class DownloadServiceTest extends AndroidTestCase { +import static org.junit.Assert.assertEquals; + +public class DownloadServiceTest { + @Test public void testRemoveDuplicateImages() { List<FeedItem> items = new ArrayList<>(); for (int i = 0; i < 50; i++) { |