diff options
author | Domingos Lopes <domingos86lopes+github@gmail.com> | 2016-05-09 22:39:50 -0400 |
---|---|---|
committer | Domingos Lopes <domingos86lopes+github@gmail.com> | 2016-07-25 23:16:28 -0400 |
commit | f80af4342f622f745aa12551e051c05ecdec6486 (patch) | |
tree | 84a4fbe8ffda966fa5bba40c1cd20bb2c5e0ec5d /core/src/main/java/de | |
parent | 9b123d04737fa9a1305b0e6827c768396ec31ca0 (diff) | |
download | AntennaPod-f80af4342f622f745aa12551e051c05ecdec6486.zip |
add documentation to post playback processing
Diffstat (limited to 'core/src/main/java/de')
-rw-r--r-- | core/src/main/java/de/danoeh/antennapod/core/service/playback/PlaybackService.java | 17 |
1 files changed, 16 insertions, 1 deletions
diff --git a/core/src/main/java/de/danoeh/antennapod/core/service/playback/PlaybackService.java b/core/src/main/java/de/danoeh/antennapod/core/service/playback/PlaybackService.java index 0da0ff325..4a8907858 100644 --- a/core/src/main/java/de/danoeh/antennapod/core/service/playback/PlaybackService.java +++ b/core/src/main/java/de/danoeh/antennapod/core/service/playback/PlaybackService.java @@ -759,7 +759,22 @@ public class PlaybackService extends MediaBrowserServiceCompat { } } - //TODO add javadoc, that is is assumed that the playable object contains info about its position and duration + /** + * This method processes the media object after its playback ended, either because it completed + * or because a different media object was selected for playback. + * + * Even though these tasks aren't supposed to be resource intensive, a good practice is to + * usually call this method on a background thread. + * + * @param playable the media object that was playing. It is assumed that its position property + * was updated before this method was called. + * @param ended if true, it signals that {@param playable} was played until its end. + * In such case, the position property of the media becomes irrelevant for most of + * the tasks (although it's still a good practice to keep it accurate). + * @param playingNext if true, it means another media object is being loaded in place of this one. + * Instances when we'd set it to false would be when we're not following the + * queue or when the queue has ended. + */ private void onPostPlayback(final Playable playable, boolean ended, boolean playingNext) { if (playable == null) { Log.e(TAG, "Cannot do post-playback processing: media was null"); |