diff options
author | orionlee <orionlee@yahoo.com> | 2018-05-02 13:53:56 -0700 |
---|---|---|
committer | orionlee <orionlee@yahoo.com> | 2018-05-02 13:53:56 -0700 |
commit | 4c7531d277bf4b2a733031b9b1d3a7e9c1ad0241 (patch) | |
tree | 39c98cce8c35c04d354e850e61ef5f63ede91824 /core/src/main/java/de/danoeh/antennapod | |
parent | ab0f4131850695537c22258633aecb4aca0aece5 (diff) | |
download | AntennaPod-4c7531d277bf4b2a733031b9b1d3a7e9c1ad0241.zip |
Flatten nested ifs, per @ByteHamster feedback
Diffstat (limited to 'core/src/main/java/de/danoeh/antennapod')
-rw-r--r-- | core/src/main/java/de/danoeh/antennapod/core/util/FeedItemUtil.java | 20 |
1 files changed, 8 insertions, 12 deletions
diff --git a/core/src/main/java/de/danoeh/antennapod/core/util/FeedItemUtil.java b/core/src/main/java/de/danoeh/antennapod/core/util/FeedItemUtil.java index 516c57d55..76a6549ae 100644 --- a/core/src/main/java/de/danoeh/antennapod/core/util/FeedItemUtil.java +++ b/core/src/main/java/de/danoeh/antennapod/core/util/FeedItemUtil.java @@ -2,7 +2,6 @@ package de.danoeh.antennapod.core.util; import java.util.List; -import de.danoeh.antennapod.core.feed.Feed; import de.danoeh.antennapod.core.feed.FeedItem; public class FeedItemUtil { @@ -81,16 +80,13 @@ public class FeedItemUtil { * use the feed's link if the named feed item has no link. */ public static String getLinkWithFallback(FeedItem item) { - String link = null; - if (item != null) { - link = item.getLink(); - if (link == null) { - Feed feed = item.getFeed(); - if (feed != null) { - link = feed.getLink(); - } - } - } // else null item, can only return null - return link; + if (item == null) { + return null; + } else if (item.getLink() != null) { + return item.getLink(); + } else if (item.getFeed() != null) { + return item.getFeed().getLink(); + } + return null; } } |