diff options
author | ByteHamster <ByteHamster@users.noreply.github.com> | 2022-04-10 18:13:56 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-04-10 18:13:56 +0200 |
commit | 8473c6f40e0520a07b3eed9276c470d9904a76e5 (patch) | |
tree | 235860175d118a390a75b657245af10a228528ee /app | |
parent | 832b51de7def1f63780c285991733522e6fbd333 (diff) | |
parent | 8ea814cfdbfdca86d87a50f7efe070f87286310b (diff) | |
download | AntennaPod-8473c6f40e0520a07b3eed9276c470d9904a76e5.zip |
Merge pull request #5833 from ByteHamster/crash-fixes
Various fixes for crashes reported through Google Play
Diffstat (limited to 'app')
3 files changed, 9 insertions, 4 deletions
diff --git a/app/src/main/java/de/danoeh/antennapod/adapter/EpisodeItemListAdapter.java b/app/src/main/java/de/danoeh/antennapod/adapter/EpisodeItemListAdapter.java index 0ad7fa219..53223896f 100644 --- a/app/src/main/java/de/danoeh/antennapod/adapter/EpisodeItemListAdapter.java +++ b/app/src/main/java/de/danoeh/antennapod/adapter/EpisodeItemListAdapter.java @@ -84,7 +84,7 @@ public class EpisodeItemListAdapter extends SelectableAdapter<EpisodeItemViewHol }); holder.itemView.setOnCreateContextMenuListener(this); holder.itemView.setOnLongClickListener(v -> { - longPressedItem = getItem(holder.getBindingAdapterPosition()); + longPressedItem = item; longPressedPosition = holder.getBindingAdapterPosition(); return false; }); @@ -92,7 +92,7 @@ public class EpisodeItemListAdapter extends SelectableAdapter<EpisodeItemViewHol if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) { if (e.isFromSource(InputDevice.SOURCE_MOUSE) && e.getButtonState() == MotionEvent.BUTTON_SECONDARY) { - longPressedItem = getItem(holder.getBindingAdapterPosition()); + longPressedItem = item; longPressedPosition = holder.getBindingAdapterPosition(); return false; } @@ -127,6 +127,7 @@ public class EpisodeItemListAdapter extends SelectableAdapter<EpisodeItemViewHol holder.itemView.setOnClickListener(null); holder.itemView.setOnCreateContextMenuListener(null); holder.itemView.setOnLongClickListener(null); + holder.itemView.setOnTouchListener(null); holder.secondaryActionButton.setOnClickListener(null); holder.dragHandle.setOnTouchListener(null); holder.coverHolder.setOnTouchListener(null); diff --git a/app/src/main/java/de/danoeh/antennapod/adapter/SubscriptionsRecyclerAdapter.java b/app/src/main/java/de/danoeh/antennapod/adapter/SubscriptionsRecyclerAdapter.java index 5ab354d05..492d49759 100644 --- a/app/src/main/java/de/danoeh/antennapod/adapter/SubscriptionsRecyclerAdapter.java +++ b/app/src/main/java/de/danoeh/antennapod/adapter/SubscriptionsRecyclerAdapter.java @@ -118,7 +118,7 @@ public class SubscriptionsRecyclerAdapter extends SelectableAdapter<Subscription if (isFeed) { longPressedPosition = holder.getBindingAdapterPosition(); } - selectedItem = (NavDrawerData.DrawerItem) getItem(holder.getBindingAdapterPosition()); + selectedItem = drawerItem; } return false; }); @@ -131,7 +131,7 @@ public class SubscriptionsRecyclerAdapter extends SelectableAdapter<Subscription if (isFeed) { longPressedPosition = holder.getBindingAdapterPosition(); } - selectedItem = (NavDrawerData.DrawerItem) getItem(holder.getBindingAdapterPosition()); + selectedItem = drawerItem; } } } diff --git a/app/src/main/java/de/danoeh/antennapod/fragment/ItemFragment.java b/app/src/main/java/de/danoeh/antennapod/fragment/ItemFragment.java index 715786921..afb0ab8c5 100644 --- a/app/src/main/java/de/danoeh/antennapod/fragment/ItemFragment.java +++ b/app/src/main/java/de/danoeh/antennapod/fragment/ItemFragment.java @@ -173,6 +173,8 @@ public class ItemFragment extends Fragment { && UsageStatistics.hasSignificantBiasTo(UsageStatistics.ACTION_STREAM)) { showOnDemandConfigBalloon(true); return; + } else if (actionButton1 == null) { + return; // Not loaded yet } actionButton1.onClick(getContext()); }); @@ -181,6 +183,8 @@ public class ItemFragment extends Fragment { && UsageStatistics.hasSignificantBiasTo(UsageStatistics.ACTION_DOWNLOAD)) { showOnDemandConfigBalloon(false); return; + } else if (actionButton2 == null) { + return; // Not loaded yet } actionButton2.onClick(getContext()); }); |