start playbackService code paths reviewed (context.startService() and

ContextCompat.startForegroundService())

1 files changed, 6 insertions, 9 deletions

diff --git a/app/src/main/java/de/danoeh/antennapod/adapter/DefaultActionButtonCallback.java b/app/src/main/java/de/danoeh/antennapod/adapter/DefaultActionButtonCallback.java
index fda6d48a5..f54b9266e 100644
--- a/app/src/main/java/de/danoeh/antennapod/adapter/DefaultActionButtonCallback.java
+++ b/app/src/main/java/de/danoeh/antennapod/adapter/DefaultActionButtonCallback.java
@@ -21,13 +21,14 @@ import de.danoeh.antennapod.core.storage.DownloadRequester;
 import de.danoeh.antennapod.core.util.IntentUtils;
 import de.danoeh.antennapod.core.util.LongList;
 import de.danoeh.antennapod.core.util.NetworkUtils;
+import de.danoeh.antennapod.core.util.playback.PlaybackServiceStarter;
 
 /**
  * Default implementation of an ActionButtonCallback
  */
 public class DefaultActionButtonCallback implements ActionButtonCallback {
 
-    private static final String TAG = "DefaultActionButtonCallback";
+    private static final String TAG = "DefaultActionBtnCb";
 
     private final Context context;
 
@@ -81,16 +82,12 @@ public class DefaultActionButtonCallback implements ActionButtonCallback {
                 }
             } else { // media is downloaded
                 if (media.isCurrentlyPlaying()) {
-//                    new PlaybackServiceStarter(context, media) // TODO: [2716] probably not needed but not 100% sure
-//                            .startWhenPrepared(true)
-//                            .shouldStream(false)
-//                            .start();
                     IntentUtils.sendLocalBroadcast(context, PlaybackService.ACTION_PAUSE_PLAY_CURRENT_EPISODE);
                 } else if (media.isCurrentlyPaused()) {
-//                    new PlaybackServiceStarter(context, media) // TODO: [2716] probably not needed but not 100% sure
-//                            .startWhenPrepared(true)
-//                            .shouldStream(false)
-//                            .start();
+                    new PlaybackServiceStarter(context, media) // need to start the service in case it's been stopped by system.
+                            .startWhenPrepared(true)
+                            .shouldStream(false)
+                            .start();
                     IntentUtils.sendLocalBroadcast(context, PlaybackService.ACTION_RESUME_PLAY_CURRENT_EPISODE);
                 } else {
                     DBTasks.playMedia(context, media, false, true, false);