Fix NonConstantResourceId code lint errors

1 files changed, 30 insertions, 38 deletions

diff --git a/app/src/main/java/de/danoeh/antennapod/menuhandler/FeedMenuHandler.java b/app/src/main/java/de/danoeh/antennapod/menuhandler/FeedMenuHandler.java
index ed0cac05d..fded5fb34 100644
--- a/app/src/main/java/de/danoeh/antennapod/menuhandler/FeedMenuHandler.java
+++ b/app/src/main/java/de/danoeh/antennapod/menuhandler/FeedMenuHandler.java
@@ -60,44 +60,36 @@ public class FeedMenuHandler {
      */
     public static boolean onOptionsItemClicked(final Context context, final MenuItem item,
                                                final Feed selectedFeed) throws DownloadRequestException {
-        switch (item.getItemId()) {
-            case R.id.refresh_item:
-                DBTasks.forceRefreshFeed(context, selectedFeed, true);
-                break;
-            case R.id.refresh_complete_item:
-                DBTasks.forceRefreshCompleteFeed(context, selectedFeed);
-                break;
-            case R.id.sort_items:
-                showSortDialog(context, selectedFeed);
-                break;
-            case R.id.filter_items:
-                showFilterDialog(context, selectedFeed);
-                break;
-            case R.id.mark_all_read_item:
-                ConfirmationDialog conDialog = new ConfirmationDialog(context,
-                        R.string.mark_all_read_label,
-                        R.string.mark_all_read_feed_confirmation_msg) {
-
-                    @Override
-                    public void onConfirmButtonPressed(
-                            DialogInterface dialog) {
-                        dialog.dismiss();
-                        DBWriter.markFeedRead(selectedFeed.getId());
-                    }
-                };
-                conDialog.createNewDialog().show();
-                break;
-            case R.id.visit_website_item:
-                IntentUtils.openInBrowser(context, selectedFeed.getLink());
-                break;
-            case R.id.share_link_item:
-                ShareUtils.shareFeedlink(context, selectedFeed);
-                break;
-            case R.id.share_download_url_item:
-                ShareUtils.shareFeedDownloadLink(context, selectedFeed);
-                break;
-            default:
-                return false;
+        final int itemId = item.getItemId();
+        if (itemId == R.id.refresh_item) {
+            DBTasks.forceRefreshFeed(context, selectedFeed, true);
+        } else if (itemId == R.id.refresh_complete_item) {
+            DBTasks.forceRefreshCompleteFeed(context, selectedFeed);
+        } else if (itemId == R.id.sort_items) {
+            showSortDialog(context, selectedFeed);
+        } else if (itemId == R.id.filter_items) {
+            showFilterDialog(context, selectedFeed);
+        } else if (itemId == R.id.mark_all_read_item) {
+            ConfirmationDialog conDialog = new ConfirmationDialog(context,
+                    R.string.mark_all_read_label,
+                    R.string.mark_all_read_feed_confirmation_msg) {
+
+                @Override
+                public void onConfirmButtonPressed(
+                        DialogInterface dialog) {
+                    dialog.dismiss();
+                    DBWriter.markFeedRead(selectedFeed.getId());
+                }
+            };
+            conDialog.createNewDialog().show();
+        } else if (itemId == R.id.visit_website_item) {
+            IntentUtils.openInBrowser(context, selectedFeed.getLink());
+        } else if (itemId == R.id.share_link_item) {
+            ShareUtils.shareFeedlink(context, selectedFeed);
+        } else if (itemId == R.id.share_download_url_item) {
+            ShareUtils.shareFeedDownloadLink(context, selectedFeed);
+        } else {
+            return false;
         }
         return true;
     }