Rewrite download request creation (#5530)

Android has a limit on the size of Intent parameters. When enqueuing
a huge number of items, it just ignored the argument and did not call
onNewIntent. We now load the list over in DownloadService.

1 files changed, 7 insertions, 12 deletions

diff --git a/app/src/main/java/de/danoeh/antennapod/fragment/actions/EpisodeMultiSelectActionHandler.java b/app/src/main/java/de/danoeh/antennapod/fragment/actions/EpisodeMultiSelectActionHandler.java
index 710ec6ce0..17642874e 100644
--- a/app/src/main/java/de/danoeh/antennapod/fragment/actions/EpisodeMultiSelectActionHandler.java
+++ b/app/src/main/java/de/danoeh/antennapod/fragment/actions/EpisodeMultiSelectActionHandler.java
@@ -11,10 +11,10 @@ import java.util.List;
 
 import de.danoeh.antennapod.R;
 import de.danoeh.antennapod.activity.MainActivity;
-import de.danoeh.antennapod.core.dialog.DownloadRequestErrorDialogCreator;
+import de.danoeh.antennapod.core.service.download.DownloadRequest;
+import de.danoeh.antennapod.core.service.download.DownloadRequestCreator;
+import de.danoeh.antennapod.core.service.download.DownloadService;
 import de.danoeh.antennapod.core.storage.DBWriter;
-import de.danoeh.antennapod.core.storage.DownloadRequestException;
-import de.danoeh.antennapod.core.storage.DownloadRequester;
 import de.danoeh.antennapod.core.util.LongList;
 import de.danoeh.antennapod.model.feed.FeedItem;
 
@@ -78,19 +78,14 @@ public class EpisodeMultiSelectActionHandler {
 
     private void downloadChecked() {
         // download the check episodes in the same order as they are currently displayed
-        List<FeedItem> toDownload = new ArrayList<>(selectedItems.size());
+        List<DownloadRequest> requests = new ArrayList<>();
         for (FeedItem episode : selectedItems) {
             if (episode.hasMedia() && !episode.getFeed().isLocalFeed()) {
-                toDownload.add(episode);
+                requests.add(DownloadRequestCreator.create(episode.getMedia()).build());
             }
         }
-        try {
-            DownloadRequester.getInstance().downloadMedia(activity, true, toDownload.toArray(new FeedItem[0]));
-        } catch (DownloadRequestException e) {
-            e.printStackTrace();
-            DownloadRequestErrorDialogCreator.newRequestErrorDialog(activity, e.getMessage());
-        }
-        showMessage(R.plurals.downloading_batch_label, toDownload.size());
+        DownloadService.download(activity, true, requests.toArray(new DownloadRequest[0]));
+        showMessage(R.plurals.downloading_batch_label, requests.size());
     }
 
     private void deleteChecked() {