summaryrefslogtreecommitdiff
path: root/app/src/main/java/de/danoeh/antennapod/activity
diff options
context:
space:
mode:
authorByteHamster <info@bytehamster.com>2020-03-25 16:09:39 +0100
committerByteHamster <info@bytehamster.com>2020-03-25 16:09:45 +0100
commita989db586a853852549c638d43c425a3463f901d (patch)
treec6f2a304e726ae9fa79ca5629b407204be4b2238 /app/src/main/java/de/danoeh/antennapod/activity
parent982ce61b3fd2d27f70c6b595544e7dc51f68b752 (diff)
downloadAntennaPod-a989db586a853852549c638d43c425a3463f901d.zip
Implemented missing PlaybackController state handling
Diffstat (limited to 'app/src/main/java/de/danoeh/antennapod/activity')
-rw-r--r--app/src/main/java/de/danoeh/antennapod/activity/MediaplayerActivity.java22
-rw-r--r--app/src/main/java/de/danoeh/antennapod/activity/MediaplayerInfoActivity.java28
-rw-r--r--app/src/main/java/de/danoeh/antennapod/activity/VideoplayerActivity.java14
3 files changed, 6 insertions, 58 deletions
diff --git a/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerActivity.java b/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerActivity.java
index 4e8269810..973ca6b98 100644
--- a/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerActivity.java
+++ b/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerActivity.java
@@ -138,16 +138,6 @@ public abstract class MediaplayerActivity extends CastEnabledActivity implements
}
@Override
- public void postStatusMsg(int msg, boolean showToast) {
- MediaplayerActivity.this.postStatusMsg(msg, showToast);
- }
-
- @Override
- public void clearStatusMsg() {
- MediaplayerActivity.this.clearStatusMsg();
- }
-
- @Override
public boolean loadMediaInfo() {
return MediaplayerActivity.this.loadMediaInfo();
}
@@ -248,12 +238,16 @@ public abstract class MediaplayerActivity extends CastEnabledActivity implements
* Should be used to inform the user that the PlaybackService is currently
* buffering.
*/
- protected abstract void onBufferStart();
+ protected void onBufferStart() {
+
+ }
/**
* Should be used to hide the view that was showing the 'buffering'-message.
*/
- protected abstract void onBufferEnd();
+ protected void onBufferEnd() {
+
+ }
private void onBufferUpdate(float progress) {
if (sbPosition != null) {
@@ -468,10 +462,6 @@ public abstract class MediaplayerActivity extends CastEnabledActivity implements
*/
protected abstract void onAwaitingVideoSurface();
- protected abstract void postStatusMsg(int resId, boolean showToast);
-
- protected abstract void clearStatusMsg();
-
void onPositionObserverUpdate() {
if (controller == null || txtvPosition == null || txtvLength == null) {
return;
diff --git a/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerInfoActivity.java b/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerInfoActivity.java
index 1a7631813..7e4ccbe23 100644
--- a/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerInfoActivity.java
+++ b/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerInfoActivity.java
@@ -127,24 +127,6 @@ public abstract class MediaplayerInfoActivity extends MediaplayerActivity {
}
@Override
- protected void postStatusMsg(int resId, boolean showToast) {
- if (resId == R.string.player_preparing_msg
- || resId == R.string.player_seeking_msg
- || resId == R.string.player_buffering_msg) {
- // TODO Show progress bar here
- }
- if (showToast) {
- Toast.makeText(this, resId, Toast.LENGTH_SHORT).show();
- }
- }
-
- @Override
- protected void clearStatusMsg() {
- // TODO Hide progress bar here
- }
-
-
- @Override
protected void setupGUI() {
super.setupGUI();
Toolbar toolbar = findViewById(R.id.toolbar);
@@ -199,16 +181,6 @@ public abstract class MediaplayerInfoActivity extends MediaplayerActivity {
}
}
- @Override
- protected void onBufferStart() {
- postStatusMsg(R.string.player_buffering_msg, false);
- }
-
- @Override
- protected void onBufferEnd() {
- clearStatusMsg();
- }
-
public PlaybackController getPlaybackController() {
return controller;
}
diff --git a/app/src/main/java/de/danoeh/antennapod/activity/VideoplayerActivity.java b/app/src/main/java/de/danoeh/antennapod/activity/VideoplayerActivity.java
index a1a4e0374..b8a30f994 100644
--- a/app/src/main/java/de/danoeh/antennapod/activity/VideoplayerActivity.java
+++ b/app/src/main/java/de/danoeh/antennapod/activity/VideoplayerActivity.java
@@ -171,20 +171,6 @@ public class VideoplayerActivity extends MediaplayerActivity {
}
}
- @Override
- protected void postStatusMsg(int resId, boolean showToast) {
- if (resId == R.string.player_preparing_msg) {
- progressIndicator.setVisibility(View.VISIBLE);
- } else {
- progressIndicator.setVisibility(View.INVISIBLE);
- }
- }
-
- @Override
- protected void clearStatusMsg() {
- progressIndicator.setVisibility(View.INVISIBLE);
- }
-
private final View.OnTouchListener onVideoviewTouched = (v, event) -> {
if (event.getAction() == MotionEvent.ACTION_DOWN) {
if (PictureInPictureUtil.isInPictureInPictureMode(this)) {