summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorH. Lehmann <ByteHamster@users.noreply.github.com>2020-05-06 13:26:40 +0200
committerGitHub <noreply@github.com>2020-05-06 13:26:40 +0200
commit9bec3cc7c4bb9fa1b0804e709d4ebef03b81ee18 (patch)
treefae95d1f5f42fc014626c7f2f8a608ff6e4c25a3
parent36c3a0da09b490c77eef6aafb0bffeb638405b45 (diff)
parent63b3ac8e04ae113e84504d68e745cc6095ad6618 (diff)
downloadAntennaPod-9bec3cc7c4bb9fa1b0804e709d4ebef03b81ee18.zip
Merge pull request #4116 from ByteHamster/non-square-images-consistency
Make subscriptions view more consistent when showing non-square images
-rw-r--r--app/src/main/res/layout/feeditemlist_item.xml2
-rw-r--r--app/src/main/res/layout/subscription_item.xml4
-rw-r--r--core/src/main/res/values/colors.xml1
3 files changed, 5 insertions, 2 deletions
diff --git a/app/src/main/res/layout/feeditemlist_item.xml b/app/src/main/res/layout/feeditemlist_item.xml
index 62ce30788..5a7ba4754 100644
--- a/app/src/main/res/layout/feeditemlist_item.xml
+++ b/app/src/main/res/layout/feeditemlist_item.xml
@@ -42,7 +42,7 @@
android:layout_marginRight="@dimen/listitem_threeline_textleftpadding"
android:layout_marginEnd="@dimen/listitem_threeline_textleftpadding"
android:id="@+id/coverHolder"
- app:cardBackgroundColor="#33777777"
+ app:cardBackgroundColor="@color/non_square_icon_background"
app:cardCornerRadius="4dp"
app:cardElevation="0dp">
diff --git a/app/src/main/res/layout/subscription_item.xml b/app/src/main/res/layout/subscription_item.xml
index a01b6d070..29f94a7e6 100644
--- a/app/src/main/res/layout/subscription_item.xml
+++ b/app/src/main/res/layout/subscription_item.xml
@@ -5,13 +5,15 @@
xmlns:tools="http://schemas.android.com/tools"
xmlns:squareImageView="http://schemas.android.com/apk/de.danoeh.antennapod"
android:layout_width="match_parent"
- android:layout_height="match_parent">
+ android:layout_height="match_parent"
+ android:foreground="?attr/selectableItemBackground">
<de.danoeh.antennapod.view.SquareImageView
android:id="@+id/imgvCover"
android:layout_width="fill_parent"
android:layout_height="fill_parent"
android:scaleType="fitCenter"
+ android:background="@color/non_square_icon_background"
tools:src="@mipmap/ic_launcher_round"
squareImageView:direction="width"/>
diff --git a/core/src/main/res/values/colors.xml b/core/src/main/res/values/colors.xml
index c553f2e14..cc04db2dd 100644
--- a/core/src/main/res/values/colors.xml
+++ b/core/src/main/res/values/colors.xml
@@ -17,6 +17,7 @@
<color name="highlight_light">#DDDDDD</color>
<color name="highlight_dark">#414141</color>
<color name="highlight_trueblack">#414141</color>
+ <color name="non_square_icon_background">#22777777</color>
<color name="accent_light">#0078C2</color>
<color name="accent_dark">#5C9DFF</color>