diff options
author | ByteHamster <info@bytehamster.com> | 2020-05-27 11:06:30 +0200 |
---|---|---|
committer | ByteHamster <info@bytehamster.com> | 2020-05-27 11:06:30 +0200 |
commit | 84b9cf9dbb050d078f836c357cf9cd79aa947065 (patch) | |
tree | 46e89019114dea884a240a8eba3334bd0739aa94 | |
parent | 018a91d66ce42e31e493117467dfa8be76301f26 (diff) | |
download | AntennaPod-84b9cf9dbb050d078f836c357cf9cd79aa947065.zip |
Cleaned up unused IDs
3 files changed, 8 insertions, 15 deletions
diff --git a/app/src/main/java/de/danoeh/antennapod/activity/MainActivity.java b/app/src/main/java/de/danoeh/antennapod/activity/MainActivity.java index 655049b2c..e05538b63 100644 --- a/app/src/main/java/de/danoeh/antennapod/activity/MainActivity.java +++ b/app/src/main/java/de/danoeh/antennapod/activity/MainActivity.java @@ -91,7 +91,7 @@ public class MainActivity extends CastEnabledActivity { super.onCreate(savedInstanceState); StorageUtils.checkStorageAvailability(this); setContentView(R.layout.main); - recycledViewPool.setMaxRecycledViews(R.id.episode_item_view_holder, 25); + recycledViewPool.setMaxRecycledViews(R.id.view_type_episode_item, 25); drawerLayout = findViewById(R.id.drawer_layout); navDrawer = findViewById(R.id.navDrawerFragment); diff --git a/app/src/main/java/de/danoeh/antennapod/adapter/EpisodeItemListAdapter.java b/app/src/main/java/de/danoeh/antennapod/adapter/EpisodeItemListAdapter.java index d391f1c54..7099d6f3a 100644 --- a/app/src/main/java/de/danoeh/antennapod/adapter/EpisodeItemListAdapter.java +++ b/app/src/main/java/de/danoeh/antennapod/adapter/EpisodeItemListAdapter.java @@ -44,7 +44,7 @@ public class EpisodeItemListAdapter extends RecyclerView.Adapter<EpisodeItemView @Override public final int getItemViewType(int position) { - return R.id.episode_item_view_holder; + return R.id.view_type_episode_item; } @NonNull diff --git a/core/src/main/res/values/ids.xml b/core/src/main/res/values/ids.xml index 8443759b4..bfb6fc9be 100644 --- a/core/src/main/res/values/ids.xml +++ b/core/src/main/res/values/ids.xml @@ -1,30 +1,23 @@ <resources> - - <item name="action_bar_refresh" type="id"/> - <item name="action_bar_add" type="id"/> - <item name="clear_queue_item" type="id"/> + <!-- Menu items --> <item name="select_all_item" type="id"/> <item name="deselect_all_item" type="id"/> - <item name="search_item" type="id"/> - <item name="enqueue_all_item" type="id"/> - <item name="download_all_item" type="id"/> <item name="clear_history_item" type="id"/> <item name="open_in_browser_item" type="id"/> <item name="copy_url_item" type="id"/> <item name="share_url_item" type="id"/> <item name="go_to_position_item" type="id"/> - <item name="organize_queue_item" type="id"/> <item name="drag_handle" type="id"/> <item name="skip_episode_item" type="id"/> <item name="move_to_top_item" type="id"/> <item name="move_to_bottom_item" type="id"/> - <item name="image_disk_cache_key" type="id"/> - <item name="imageloader_key" type="id"/> + + <!-- View types --> + <item name="view_type_episode_item" type="id"/> + + <!-- Notifications need unique IDs to update/cancel them --> <item name="notification_gpodnet_sync_error" type="id"/> <item name="notification_gpodnet_sync_autherror" type="id"/> - <item name="undobar_button" type="id"/> - <item name="undobar_message" type="id"/> - <item name="episode_item_view_holder" type="id"/> <!-- PendingIntent objects that use the same action but different extras need to use a unique request code --> <item name="pending_intent_download_service_notification" type="id"/> |