Merge pull request #3720 from ByteHamster/do-not-allocate-arrays

Do not allocate space for arrays that do not need to be allocated

4 files changed, 4 insertions, 6 deletions

diff --git a/app/src/androidTest/java/de/test/antennapod/ui/UITestUtils.java b/app/src/androidTest/java/de/test/antennapod/ui/UITestUtils.java
index 8e16d1a3b..936337cbf 100644
--- a/app/src/androidTest/java/de/test/antennapod/ui/UITestUtils.java
+++ b/app/src/androidTest/java/de/test/antennapod/ui/UITestUtils.java
@@ -201,7 +201,7 @@ public class UITestUtils {
 
         PodDBAdapter adapter = PodDBAdapter.getInstance();
         adapter.open();
-        adapter.setCompleteFeed(hostedFeeds.toArray(new Feed[hostedFeeds.size()]));
+        adapter.setCompleteFeed(hostedFeeds.toArray(new Feed[0]));
         adapter.setQueue(queue);
         adapter.close();
         EventBus.getDefault().post(new FeedListUpdateEvent(hostedFeeds));
diff --git a/app/src/main/java/de/danoeh/antennapod/dialog/EpisodesApplyActionFragment.java b/app/src/main/java/de/danoeh/antennapod/dialog/EpisodesApplyActionFragment.java
index 2e1cc2c7d..d583c0e1e 100644
--- a/app/src/main/java/de/danoeh/antennapod/dialog/EpisodesApplyActionFragment.java
+++ b/app/src/main/java/de/danoeh/antennapod/dialog/EpisodesApplyActionFragment.java
@@ -485,7 +485,7 @@ public class EpisodesApplyActionFragment extends Fragment {
             }
         }
         try {
-            DownloadRequester.getInstance().downloadMedia(getActivity(), toDownload.toArray(new FeedItem[toDownload.size()]));
+            DownloadRequester.getInstance().downloadMedia(getActivity(), toDownload.toArray(new FeedItem[0]));
         } catch (DownloadRequestException e) {
             e.printStackTrace();
             DownloadRequestErrorDialogCreator.newRequestErrorDialog(getActivity(), e.getMessage());
diff --git a/app/src/main/java/de/danoeh/antennapod/fragment/preferences/AutoDownloadPreferencesFragment.java b/app/src/main/java/de/danoeh/antennapod/fragment/preferences/AutoDownloadPreferencesFragment.java
index fa17fed0a..469697e23 100644
--- a/app/src/main/java/de/danoeh/antennapod/fragment/preferences/AutoDownloadPreferencesFragment.java
+++ b/app/src/main/java/de/danoeh/antennapod/fragment/preferences/AutoDownloadPreferencesFragment.java
@@ -131,9 +131,7 @@ public class AutoDownloadPreferencesFragment extends PreferenceFragmentCompat {
                     prefValuesList.add(key);
                 }
 
-                UserPreferences.setAutodownloadSelectedNetworks(
-                        prefValuesList.toArray(new String[prefValuesList.size()])
-                );
+                UserPreferences.setAutodownloadSelectedNetworks(prefValuesList.toArray(new String[0]));
                 return true;
             } else {
                 return false;
diff --git a/app/src/main/java/de/danoeh/antennapod/menuhandler/FeedMenuHandler.java b/app/src/main/java/de/danoeh/antennapod/menuhandler/FeedMenuHandler.java
index e32deba27..44b6453e5 100644
--- a/app/src/main/java/de/danoeh/antennapod/menuhandler/FeedMenuHandler.java
+++ b/app/src/main/java/de/danoeh/antennapod/menuhandler/FeedMenuHandler.java
@@ -108,7 +108,7 @@ public class FeedMenuHandler {
         FilterDialog filterDialog = new FilterDialog(context, selectedFeed.getItemFilter()) {
             @Override
             protected void updateFilter(Set<String> filterValues) {
-                selectedFeed.setItemFilter(filterValues.toArray(new String[filterValues.size()]));
+                selectedFeed.setItemFilter(filterValues.toArray(new String[0]));
                 DBWriter.setFeedItemsFilter(selectedFeed.getId(), filterValues);
             }
         };