diff options
| author | orionlee <orionlee@yahoo.com> | 2019-03-05 15:01:48 -0800 |
|---|---|---|
| committer | orionlee <orionlee@yahoo.com> | 2019-03-05 15:01:48 -0800 |
| commit | 24915785eb76b57884a446e92bd24af9c5473c5e (patch) | |
| tree | 2e451617e2e002a13c2dace64fceb994f058d5f7 | |
| parent | e94e95e84430f18b43899238f742c67256bb82e4 (diff) | |
| download | AntennaPod-24915785eb76b57884a446e92bd24af9c5473c5e.zip | |
remove the stopService() per review (which might unnecessarily
stop the playback when unsupported media buttons are pressed.)
| -rw-r--r-- | core/src/main/java/de/danoeh/antennapod/core/service/playback/PlaybackService.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/core/src/main/java/de/danoeh/antennapod/core/service/playback/PlaybackService.java b/core/src/main/java/de/danoeh/antennapod/core/service/playback/PlaybackService.java index 44324be32..491493036 100644 --- a/core/src/main/java/de/danoeh/antennapod/core/service/playback/PlaybackService.java +++ b/core/src/main/java/de/danoeh/antennapod/core/service/playback/PlaybackService.java @@ -468,7 +468,8 @@ public class PlaybackService extends MediaBrowserServiceCompat { Log.d(TAG, "Received media button event"); boolean handled = handleKeycode(keycode, true); if (!handled) { - serviceManager.stopService(); // TODO: [2716]-RemoveOptional why is it added in the first place in v1.7.0? + // Just silently ignores unsupported keycode. Whether the service will + // continue to run is solely dependent on whether it is playing some media. return Service.START_NOT_STICKY; } } else if (!flavorHelper.castDisconnect(castDisconnect) && playable != null) { |