diff options
| author | John Snow <jsnow@redhat.com> | 2021-09-30 16:57:05 -0400 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2021-10-02 07:33:41 +0200 |
| commit | 2adb988ed4ca31813d237c475a6a327ef16c5432 (patch) | |
| tree | 813574d576b0fac9c62b77c3553a55d95659a139 /scripts | |
| parent | 1c00917409c9604cfc587045ba37395a48337dff (diff) | |
| download | qemu-2adb988ed4ca31813d237c475a6a327ef16c5432.zip | |
qapi/gen: use dict.items() to iterate over _modules
New pylint warning. I could silence it, but this is the only occurrence
in the entire tree, including everything in iotests/ and python/. Easier
to just change this one instance.
(The warning is emitted in cases where you are fetching the values
anyway, so you may as well just take advantage of the iterator to avoid
redundant lookups.)
Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20210930205716.1148693-3-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/qapi/gen.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py index ab26d5c937..2ec1e7b3b6 100644 --- a/scripts/qapi/gen.py +++ b/scripts/qapi/gen.py @@ -296,10 +296,9 @@ class QAPISchemaModularCVisitor(QAPISchemaVisitor): self._current_module = old_module def write(self, output_dir: str, opt_builtins: bool = False) -> None: - for name in self._module: + for name, (genc, genh) in self._module.items(): if QAPISchemaModule.is_builtin_module(name) and not opt_builtins: continue - (genc, genh) = self._module[name] genc.write(output_dir) genh.write(output_dir) |