summaryrefslogtreecommitdiff
path: root/autoload
diff options
context:
space:
mode:
authornospam2998 <98894405+nospam2998@users.noreply.github.com>2022-02-04 18:56:48 +0100
committerGitHub <noreply@github.com>2022-02-04 17:56:48 +0000
commita58b7b5efb058ca8ba597289af2ab49ee56bfc46 (patch)
tree5083ba4f43633706a75880214ea32b7657876f01 /autoload
parent5856c067755d5ff9e14c306d93d1a3605ee966fc (diff)
downloadale-a58b7b5efb058ca8ba597289af2ab49ee56bfc46.zip
Treat ale_open_list integer values as thresholds (#4050)
Only open list window if the number of warnings or errors equals to or exceeds the value of ale_open_list. No change when set to `1`. Co-authored-by: cos <cos>
Diffstat (limited to 'autoload')
-rw-r--r--autoload/ale/list.vim24
1 files changed, 17 insertions, 7 deletions
diff --git a/autoload/ale/list.vim b/autoload/ale/list.vim
index 7865cf70..f10d0910 100644
--- a/autoload/ale/list.vim
+++ b/autoload/ale/list.vim
@@ -36,12 +36,22 @@ function! ale#list#IsQuickfixOpen() abort
endfunction
" Check if we should open the list, based on the save event being fired, and
-" that setting being on, or the setting just being set to `1`.
-function! s:ShouldOpen(buffer) abort
+" that setting being on, or that the error count is at least as high as the
+" setting when set to an integer value.
+function! s:ShouldOpen(buffer, loclist_len) abort
let l:val = ale#Var(a:buffer, 'open_list')
let l:saved = getbufvar(a:buffer, 'ale_save_event_fired', 0)
- return l:val is 1 || (l:val is# 'on_save' && l:saved)
+ return l:val > 0 ? a:loclist_len >= l:val : l:val is# 'on_save' && l:saved
+endfunction
+
+" Check if we should close the list, based on the save event being fired, and
+" that setting being on, or the setting just being set to an integer value.
+function! s:ShouldClose(buffer) abort
+ let l:val = ale#Var(a:buffer, 'open_list')
+ let l:saved = getbufvar(a:buffer, 'ale_save_event_fired', 0)
+
+ return !((l:val >= 1) || (l:val is# 'on_save' && l:saved))
endfunction
function! s:Deduplicate(list) abort
@@ -122,9 +132,9 @@ function! s:SetListsImpl(timer_id, buffer, loclist) abort
" Open a window to show the problems if we need to.
"
- " We'll check if the current buffer's List is not empty here, so the
- " window will only be opened if the current buffer has problems.
- if s:ShouldOpen(a:buffer) && !empty(a:loclist)
+ " ShouldOpen() checks if the current buffer has enough problems to be
+ " opened.
+ if s:ShouldOpen(a:buffer, len(a:loclist))
let l:winnr = winnr()
let l:mode = mode()
@@ -230,7 +240,7 @@ function! ale#list#ForcePopulateErrorList(populate_quickfix) abort
endfunction
function! s:CloseWindowIfNeeded(buffer) abort
- if ale#Var(a:buffer, 'keep_list_window_open') || !s:ShouldOpen(a:buffer)
+ if ale#Var(a:buffer, 'keep_list_window_open') || s:ShouldClose(a:buffer)
return
endif