Fix `ale#util#GetBufferContents` and propagate use (#4457)

* Use newline characters instead in ale#util#GetBufferContents
* Propagate use of ale#util#GetBufferContents
* Add ale#util#GetContentBuffer test

1 files changed, 2 insertions, 6 deletions

diff --git a/autoload/ale/lsp/message.vim b/autoload/ale/lsp/message.vim
index c2238dec..9d5b6228 100644
--- a/autoload/ale/lsp/message.vim
+++ b/autoload/ale/lsp/message.vim
@@ -52,28 +52,24 @@ function! ale#lsp#message#Exit() abort
 endfunction
 
 function! ale#lsp#message#DidOpen(buffer, language_id) abort
-    let l:lines = getbufline(a:buffer, 1, '$')
-
     return [1, 'textDocument/didOpen', {
     \   'textDocument': {
     \       'uri': ale#util#ToURI(expand('#' . a:buffer . ':p')),
     \       'languageId': a:language_id,
     \       'version': ale#lsp#message#GetNextVersionID(),
-    \       'text': join(l:lines, "\n") . "\n",
+    \       'text': ale#util#GetBufferContents(a:buffer),
     \   },
     \}]
 endfunction
 
 function! ale#lsp#message#DidChange(buffer) abort
-    let l:lines = getbufline(a:buffer, 1, '$')
-
     " For changes, we simply send the full text of the document to the server.
     return [1, 'textDocument/didChange', {
     \   'textDocument': {
     \       'uri': ale#util#ToURI(expand('#' . a:buffer . ':p')),
     \       'version': ale#lsp#message#GetNextVersionID(),
     \   },
-    \   'contentChanges': [{'text': join(l:lines, "\n") . "\n"}]
+    \   'contentChanges': [{'text': ale#util#GetBufferContents(a:buffer)}]
     \}]
 endfunction