Support pylama for python (#2266)

* Add pylama for python
* Consolidate python traceback handling

3 files changed, 104 insertions, 20 deletions

diff --git a/ale_linters/python/flake8.vim b/ale_linters/python/flake8.vim
index b5b5f3cc..076bd9c4 100644
--- a/ale_linters/python/flake8.vim
+++ b/ale_linters/python/flake8.vim
@@ -74,15 +74,11 @@ let s:end_col_pattern_map = {
 \}
 
 function! ale_linters#python#flake8#Handle(buffer, lines) abort
-    for l:line in a:lines[:10]
-        if match(l:line, '^Traceback') >= 0
-            return [{
-            \   'lnum': 1,
-            \   'text': 'An exception was thrown. See :ALEDetail',
-            \   'detail': join(a:lines, "\n"),
-            \}]
-        endif
-    endfor
+    let l:output = ale#python#HandleTraceback(a:lines, 10)
+
+    if !empty(l:output)
+        return l:output
+    endif
 
     " Matches patterns line the following:
     "
@@ -90,7 +86,6 @@ function! ale_linters#python#flake8#Handle(buffer, lines) abort
     "
     " stdin:6:6: E111 indentation is not a multiple of four
     let l:pattern = '\v^[a-zA-Z]?:?[^:]+:(\d+):?(\d+)?: ([[:alnum:]]+):? (.*)$'
-    let l:output = []
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         let l:code = l:match[3]
diff --git a/ale_linters/python/pylama.vim b/ale_linters/python/pylama.vim
new file mode 100644
index 00000000..52b7c8c8
--- /dev/null
+++ b/ale_linters/python/pylama.vim
@@ -0,0 +1,94 @@
+" Author: Kevin Locke <kevin@kevinlocke.name>
+" Description: pylama for python files
+
+call ale#Set('python_pylama_executable', 'pylama')
+call ale#Set('python_pylama_options', '')
+call ale#Set('python_pylama_use_global', get(g:, 'ale_use_global_executables', 0))
+call ale#Set('python_pylama_auto_pipenv', 0)
+call ale#Set('python_pylama_change_directory', 1)
+
+function! ale_linters#python#pylama#GetExecutable(buffer) abort
+    if (ale#Var(a:buffer, 'python_auto_pipenv') || ale#Var(a:buffer, 'python_pylama_auto_pipenv'))
+    \ && ale#python#PipenvPresent(a:buffer)
+        return 'pipenv'
+    endif
+
+    return ale#python#FindExecutable(a:buffer, 'python_pylama', ['pylama'])
+endfunction
+
+function! ale_linters#python#pylama#GetCommand(buffer) abort
+    let l:cd_string = ''
+
+    if ale#Var(a:buffer, 'python_pylama_change_directory')
+        " Pylama loads its configuration from the current directory only, and
+        " applies file masks using paths relative to the current directory.
+        " Run from project root, if found, otherwise buffer dir.
+        let l:project_root = ale#python#FindProjectRoot(a:buffer)
+        let l:cd_string = l:project_root isnot# ''
+        \   ? ale#path#CdString(l:project_root)
+        \   : ale#path#BufferCdString(a:buffer)
+    endif
+
+    let l:executable = ale_linters#python#pylama#GetExecutable(a:buffer)
+    let l:exec_args = l:executable =~? 'pipenv$'
+    \   ? ' run pylama'
+    \   : ''
+
+    return l:cd_string
+    \   . ale#Escape(l:executable) . l:exec_args
+    \   . ale#Pad(ale#Var(a:buffer, 'python_pylama_options'))
+    \   . ' %t'
+endfunction
+
+function! ale_linters#python#pylama#Handle(buffer, lines) abort
+    if empty(a:lines)
+        return []
+    endif
+
+    let l:output = ale#python#HandleTraceback(a:lines, 1)
+    let l:pattern = '\v^.{-}:([0-9]+):([0-9]+): +%(([A-Z][0-9]+):? +)?(.*)$'
+
+    " First letter of error code is a pylint-compatible message type
+    " http://pylint.pycqa.org/en/latest/user_guide/output.html#source-code-analysis-section
+    " D is for Documentation (pydocstyle)
+    let l:pylint_type_to_ale_type = {
+    \   'I': 'I',
+    \   'R': 'W',
+    \   'C': 'W',
+    \   'W': 'W',
+    \   'E': 'E',
+    \   'F': 'E',
+    \   'D': 'W',
+    \}
+    let l:pylint_type_to_ale_sub_type = {
+    \   'R': 'style',
+    \   'C': 'style',
+    \   'D': 'style',
+    \}
+
+    for l:match in ale#util#GetMatches(a:lines, l:pattern)
+        " Ignore C0103 for module name from temporary path (%t) which may not
+        " comply with module-rgx.
+        if l:match[3] is# 'C0103' && l:match[4] =~# '^Module name '
+            continue
+        endif
+
+        call add(l:output, {
+        \   'lnum': str2nr(l:match[1]),
+        \   'col': str2nr(l:match[2]),
+        \   'code': l:match[3],
+        \   'type': get(l:pylint_type_to_ale_type, l:match[3][0], 'W'),
+        \   'sub_type': get(l:pylint_type_to_ale_sub_type, l:match[3][0], ''),
+        \   'text': l:match[4],
+        \})
+    endfor
+
+    return l:output
+endfunction
+
+call ale#linter#Define('python', {
+\   'name': 'pylama',
+\   'executable_callback': 'ale_linters#python#pylama#GetExecutable',
+\   'command_callback': 'ale_linters#python#pylama#GetCommand',
+\   'callback': 'ale_linters#python#pylama#Handle',
+\})
diff --git a/ale_linters/python/vulture.vim b/ale_linters/python/vulture.vim
index 80828013..b3908b80 100644
--- a/ale_linters/python/vulture.vim
+++ b/ale_linters/python/vulture.vim
@@ -46,19 +46,14 @@ endfunction
 
 
 function! ale_linters#python#vulture#Handle(buffer, lines) abort
-    for l:line in a:lines[:10]
-        if match(l:line, '^Traceback') >= 0
-            return [{
-            \   'lnum': 1,
-            \   'text': 'An exception was thrown. See :ALEDetail',
-            \   'detail': join(a:lines, "\n"),
-            \}]
-        endif
-    endfor
+    let l:output = ale#python#HandleTraceback(a:lines, 10)
+
+    if !empty(l:output)
+        return l:output
+    endif
 
     " Matches patterns line the following:
     let l:pattern = '\v^([a-zA-Z]?:?[^:]+):(\d+): (.*)$'
-    let l:output = []
     let l:dir = s:GetDir(a:buffer)
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)