diff options
| author | w0rp <devw0rp@gmail.com> | 2017-08-16 10:37:36 +0100 |
|---|---|---|
| committer | w0rp <devw0rp@gmail.com> | 2017-08-16 10:37:36 +0100 |
| commit | 342e83db60dd929cbef1d00e1864e607760ca9bb (patch) | |
| tree | 11f64fb97f28a29daf3aa79842d40640885ec522 | |
| parent | 17a76a74035488112eb6df92c2a11cb0f177fec9 (diff) | |
| download | ale-342e83db60dd929cbef1d00e1864e607760ca9bb.zip | |
Include the ruleName for errors in tslint problems
| -rw-r--r-- | ale_linters/typescript/tslint.vim | 4 | ||||
| -rw-r--r-- | test/handler/test_tslint_handler.vader | 5 |
2 files changed, 5 insertions, 4 deletions
diff --git a/ale_linters/typescript/tslint.vim b/ale_linters/typescript/tslint.vim index cdc896e1..4db5094f 100644 --- a/ale_linters/typescript/tslint.vim +++ b/ale_linters/typescript/tslint.vim @@ -18,7 +18,9 @@ function! ale_linters#typescript#tslint#Handle(buffer, lines) abort if ale#path#IsBufferPath(a:buffer, l:error.name) call add(l:output, { \ 'type': (get(l:error, 'ruleSeverity', '') is# 'WARNING' ? 'W' : 'E'), - \ 'text': l:error.failure, + \ 'text': has_key(l:error, 'ruleName') + \ ? l:error.ruleName . ': ' . l:error.failure + \ : l:error.failure, \ 'lnum': l:error.startPosition.line + 1, \ 'col': l:error.startPosition.character + 1, \ 'end_lnum': l:error.endPosition.line + 1, diff --git a/test/handler/test_tslint_handler.vader b/test/handler/test_tslint_handler.vader index 704123dd..a27657eb 100644 --- a/test/handler/test_tslint_handler.vader +++ b/test/handler/test_tslint_handler.vader @@ -17,7 +17,7 @@ Execute(The tslint handler should parse lines correctly): \ 'col': 15, \ 'end_lnum': 1, \ 'end_col': 15, - \ 'text': 'Missing semicolon', + \ 'text': 'semicolon: Missing semicolon', \ 'type': 'E', \ }, \ { @@ -33,7 +33,7 @@ Execute(The tslint handler should parse lines correctly): \ 'col': 9, \ 'end_lnum': 31, \ 'end_col': 20, - \ 'text': 'Calls to console.log are not allowed.', + \ 'text': 'no-console: Calls to console.log are not allowed.', \ 'type': 'E', \ }, \ ], @@ -72,7 +72,6 @@ Execute(The tslint handler should parse lines correctly): \ 'innerText': ';' \ }, \ 'name': 'app/test.ts', - \ 'ruleName': 'something', \ 'ruleSeverity': 'WARNING', \ 'startPosition': { \ 'character': 7, |