diff options
| author | w0rp <w0rp@users.noreply.github.com> | 2017-03-13 23:18:06 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-03-13 23:18:06 +0000 |
| commit | 3f3d8b001470979864af7317075f38779bc46518 (patch) | |
| tree | a7abed205cbd1dffef19bd4307a410e22213a641 | |
| parent | 711ab9936274608dad48b20b58727c416672c115 (diff) | |
| parent | e969d97843ca6a8f2beddf05f45d2733c0589a52 (diff) | |
| download | ale-3f3d8b001470979864af7317075f38779bc46518.zip | |
Merge pull request #393 from naoina/fix-coffeelint-pattern
Fix pattern of output for coffeelint
| -rw-r--r-- | ale_linters/coffee/coffeelint.vim | 2 | ||||
| -rw-r--r-- | test/handler/test_coffeelint_handler.vader | 20 |
2 files changed, 21 insertions, 1 deletions
diff --git a/ale_linters/coffee/coffeelint.vim b/ale_linters/coffee/coffeelint.vim index a7960b98..e32f7b79 100644 --- a/ale_linters/coffee/coffeelint.vim +++ b/ale_linters/coffee/coffeelint.vim @@ -21,7 +21,7 @@ function! ale_linters#coffee#coffeelint#Handle(buffer, lines) abort " stdin,14,,error,Throwing strings is forbidden " " Note that we currently ignore lineNumberEnd for multiline errors - let l:pattern = 'stdin,\(\d\+\),\(\d*\),\(.\+\),\(.\+\)' + let l:pattern = 'stdin,\(\d\+\),\(\d*\),\(.\{-1,}\),\(.\+\)' let l:output = [] for l:line in a:lines diff --git a/test/handler/test_coffeelint_handler.vader b/test/handler/test_coffeelint_handler.vader new file mode 100644 index 00000000..2d56e7c8 --- /dev/null +++ b/test/handler/test_coffeelint_handler.vader @@ -0,0 +1,20 @@ +Execute(The coffeelint handler should parse lines correctly): + runtime ale_linters/coffee/coffeelint.vim + + AssertEqual + \ [ + \ { + \ 'bufnr': 347, + \ 'lnum': 125, + \ 'col': 1, + \ 'text': "Line exceeds maximum allowed length Length is 122, max is 120.", + \ 'type': 'E', + \ }, + \ ], + \ ale_linters#coffee#coffeelint#Handle(347, [ + \ "path,lineNumber,lineNumberEnd,level,message", + \ "stdin,125,,error,Line exceeds maximum allowed length Length is 122, max is 120.", + \ ]) + +After: + call ale#linter#Reset() |