diff options
| author | Rob Whittaker <rob@purinkle.co.uk> | 2023-05-26 06:52:51 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-26 14:52:51 +0900 |
| commit | 7021ed0c6859ec8b1bf5012d1276d54a786449c3 (patch) | |
| tree | c8a764dc655ff4eccfcf22146dd68f02274be0bd | |
| parent | a46121a532b2baaa339016ab910c59f1cded46e5 (diff) | |
| download | ale-7021ed0c6859ec8b1bf5012d1276d54a786449c3.zip | |
š Fix a Ruby deprecation warning in the ERB linter (#4521)
* Fix a Ruby deprecation warning in the ERB linter
Before, the ERB linter used positional arguments. Newer versions of Ruby
have deprecated this method signature. We fixed the linter to use
keyword arguments.
* fixup! Fix a Ruby deprecation warning in the ERB linter
| -rw-r--r-- | ale_linters/eruby/erb.vim | 2 | ||||
| -rw-r--r-- | test/linter/test_erb.vader | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/ale_linters/eruby/erb.vim b/ale_linters/eruby/erb.vim index f3438320..0ca157aa 100644 --- a/ale_linters/eruby/erb.vim +++ b/ale_linters/eruby/erb.vim @@ -11,7 +11,7 @@ function! ale_linters#eruby#erb#GetCommand(buffer) abort " Rails-flavored eRuby does not comply with the standard as understood by " ERB, so we'll have to do some substitution. This does not reduce the " effectiveness of the linterāthe translated code is still evaluated. - return 'ruby -r erb -e ' . ale#Escape('puts ERB.new($stdin.read.gsub(%{<%=},%{<%}), nil, %{-}).src') . '< %t | ruby -c' + return 'ruby -r erb -e ' . ale#Escape('puts ERB.new($stdin.read.gsub(%{<%=},%{<%}), trim_mode: %{-}).src') . '< %t | ruby -c' endfunction call ale#linter#Define('eruby', { diff --git a/test/linter/test_erb.vader b/test/linter/test_erb.vader index c64c7ba5..4adffcba 100644 --- a/test/linter/test_erb.vader +++ b/test/linter/test_erb.vader @@ -13,4 +13,4 @@ Execute(Executable should filter invalid eRuby when inside a Rails project): call ale#test#SetFilename('../test-files/ruby/valid_rails_app/app/views/my_great_view.html.erb') AssertLinter 'erb', - \ 'ruby -r erb -e ' . ale#Escape('puts ERB.new($stdin.read.gsub(%{<%=},%{<%}), nil, %{-}).src') . '< %t | ruby -c' + \ 'ruby -r erb -e ' . ale#Escape('puts ERB.new($stdin.read.gsub(%{<%=},%{<%}), trim_mode: %{-}).src') . '< %t | ruby -c' |