diff options
author | Wez Furlong <wez@wezfurlong.org> | 2019-08-01 09:05:26 -0700 |
---|---|---|
committer | Wez Furlong <wez@wezfurlong.org> | 2019-08-01 09:05:26 -0700 |
commit | cab5f0fc9f217a577ad7614e5539e0d0315279b1 (patch) | |
tree | 5f3382e3f07ea45189f05062376e1194212a715f /libssh2-sys/libssh2 | |
parent | ba6b5eddcf5bc93ca6f0475e76e157e3bdda6b64 (diff) | |
download | ssh2-rs-cab5f0fc9f217a577ad7614e5539e0d0315279b1.zip |
move tcpstream assignment to its own function
The recent move to take ownership of TcpStream exposed an issue with
the `handshake` method: if the stream is non-blocking then it may
take several attempts to handshake, but only the first one is able
to transfer ownership.
My initial thought was just to make the TcpStream a required parameter
to `new`, but we have some tests that work with known hosts and the
ssh agent that don't require a tcpstream.
I'm going to review those and see if there is a cleaner overall
solution, but that will likely require more substantial API changes.
For now, the simplest change is to add a separate `set_tcp_stream`
function to make the stream ownership transfer explicit and distinct
from the handshake.
Refs: https://github.com/alexcrichton/ssh2-rs/issues/17
Diffstat (limited to 'libssh2-sys/libssh2')
m--------- | libssh2-sys/libssh2 | 0 |
1 files changed, 0 insertions, 0 deletions
diff --git a/libssh2-sys/libssh2 b/libssh2-sys/libssh2 -Subproject 6d70b26ab602d112707890608455caf29ec9a35 +Subproject 1bbb96e41bf298fb525e5bcf64566f43e8fd4c8 |