summaryrefslogtreecommitdiff
path: root/.travis.yml
diff options
context:
space:
mode:
authorWez Furlong <wez@wezfurlong.org>2019-08-01 09:05:26 -0700
committerWez Furlong <wez@wezfurlong.org>2019-08-01 09:05:26 -0700
commitcab5f0fc9f217a577ad7614e5539e0d0315279b1 (patch)
tree5f3382e3f07ea45189f05062376e1194212a715f /.travis.yml
parentba6b5eddcf5bc93ca6f0475e76e157e3bdda6b64 (diff)
downloadssh2-rs-cab5f0fc9f217a577ad7614e5539e0d0315279b1.zip
move tcpstream assignment to its own function
The recent move to take ownership of TcpStream exposed an issue with the `handshake` method: if the stream is non-blocking then it may take several attempts to handshake, but only the first one is able to transfer ownership. My initial thought was just to make the TcpStream a required parameter to `new`, but we have some tests that work with known hosts and the ssh agent that don't require a tcpstream. I'm going to review those and see if there is a cleaner overall solution, but that will likely require more substantial API changes. For now, the simplest change is to add a separate `set_tcp_stream` function to make the stream ownership transfer explicit and distinct from the handshake. Refs: https://github.com/alexcrichton/ssh2-rs/issues/17
Diffstat (limited to '.travis.yml')
0 files changed, 0 insertions, 0 deletions