From 12cd30f1acd6bccfba07d3054d71feb0467a3d78 Mon Sep 17 00:00:00 2001
From: thankyouverycool <66646555+thankyouverycool@users.noreply.github.com>
Date: Thu, 15 Dec 2022 12:03:07 -0500
Subject: LibGUI: Ensure GlyphMapWidget selection resets when requested

Previously selection reset was ignored on active glyph change if the
old glyph equaled the new one. This was an intentional behavior that
allowed selections to resize by dragging the focused glyph, but has
proved more counterintuitive than useful.

Now the widget behaves like other text selection controls: selections
can be reset by clicking anywhere in them or shift can be held to
grow the selection.
---
 Userland/Libraries/LibGUI/GlyphMapWidget.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'Userland')

diff --git a/Userland/Libraries/LibGUI/GlyphMapWidget.cpp b/Userland/Libraries/LibGUI/GlyphMapWidget.cpp
index be2ca8a094..9157ebda58 100644
--- a/Userland/Libraries/LibGUI/GlyphMapWidget.cpp
+++ b/Userland/Libraries/LibGUI/GlyphMapWidget.cpp
@@ -77,7 +77,7 @@ void GlyphMapWidget::resize_event(ResizeEvent& event)
 
 void GlyphMapWidget::set_active_glyph(int glyph, ShouldResetSelection should_reset_selection)
 {
-    if (m_active_glyph == glyph)
+    if (m_active_glyph == glyph && should_reset_selection == ShouldResetSelection::No)
         return;
     m_active_glyph = glyph;
     if (should_reset_selection == ShouldResetSelection::Yes) {
-- 
cgit v1.2.3