From b345a0acca725d1b4e4d6df26fc602d69e97f073 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Mon, 22 Aug 2022 19:00:49 +0100 Subject: LibJS+LibWeb: Reduce use of GlobalObject as an intermediary - Prefer VM::current_realm() over GlobalObject::associated_realm() - Prefer VM::heap() over GlobalObject::heap() - Prefer Cell::vm() over Cell::global_object() - Prefer Wrapper::vm() over Wrapper::global_object() - Inline Realm::global_object() calls used to access intrinsics as they will later perform a direct lookup without going through the global object --- Userland/Services/WebContent/WebContentConsoleClient.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'Userland/Services') diff --git a/Userland/Services/WebContent/WebContentConsoleClient.cpp b/Userland/Services/WebContent/WebContentConsoleClient.cpp index 9e3922e97a..a94c1ff774 100644 --- a/Userland/Services/WebContent/WebContentConsoleClient.cpp +++ b/Userland/Services/WebContent/WebContentConsoleClient.cpp @@ -25,13 +25,13 @@ WebContentConsoleClient::WebContentConsoleClient(JS::Console& console, WeakPtrvm(); auto& realm = m_interpreter->realm(); - auto& global_object = realm.global_object(); + auto& window = static_cast(realm.global_object()); - auto console_global_object = m_interpreter->heap().allocate_without_realm(m_interpreter->realm(), static_cast(global_object)); + auto console_global_object = m_interpreter->heap().allocate_without_realm(realm, window); // NOTE: We need to push an execution context here for NativeFunction::create() to succeed during global object initialization. // It gets removed immediately after creating the interpreter in Document::interpreter(). - auto& eso = verify_cast(*m_interpreter->realm().host_defined()); + auto& eso = verify_cast(*realm.host_defined()); vm.push_execution_context(eso.realm_execution_context()); console_global_object->set_associated_realm(realm); console_global_object->initialize_global_object(realm); -- cgit v1.2.3