From b33a6a443e700cd80325d312f21c985b0687bb97 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Tue, 23 Feb 2021 20:32:52 +0100 Subject: LibELF: Inline DynamicObject::hash_section() This was high up in profiles and gets almost entirely optimized out when inlined, so let's do that. --- Userland/Libraries/LibELF/DynamicObject.cpp | 8 -------- Userland/Libraries/LibELF/DynamicObject.h | 8 +++++++- 2 files changed, 7 insertions(+), 9 deletions(-) (limited to 'Userland/Libraries') diff --git a/Userland/Libraries/LibELF/DynamicObject.cpp b/Userland/Libraries/LibELF/DynamicObject.cpp index 8b3bd8c0bb..9505a87809 100644 --- a/Userland/Libraries/LibELF/DynamicObject.cpp +++ b/Userland/Libraries/LibELF/DynamicObject.cpp @@ -233,14 +233,6 @@ DynamicObject::Section DynamicObject::fini_array_section() const return Section(*this, m_fini_array_offset, m_fini_array_size, sizeof(void (*)()), "DT_FINI_ARRAY"); } -DynamicObject::HashSection DynamicObject::hash_section() const -{ - auto section_name = m_hash_type == HashType::SYSV - ? StringView { "DT_HASH", 7 } - : StringView { "DT_GNU_HASH", 11 }; - return HashSection(Section(*this, m_hash_table_offset, 0, 0, section_name), m_hash_type); -} - DynamicObject::RelocationSection DynamicObject::relocation_section() const { return RelocationSection(Section(*this, m_relocation_table_offset, m_size_of_relocation_table, m_size_of_relocation_entry, "DT_REL")); diff --git a/Userland/Libraries/LibELF/DynamicObject.h b/Userland/Libraries/LibELF/DynamicObject.h index 3a1a183728..075b176508 100644 --- a/Userland/Libraries/LibELF/DynamicObject.h +++ b/Userland/Libraries/LibELF/DynamicObject.h @@ -217,7 +217,13 @@ public: Section init_array_section() const; Section fini_array_section() const; - HashSection hash_section() const; + HashSection hash_section() const + { + auto section_name = m_hash_type == HashType::SYSV + ? StringView { "DT_HASH", 7 } + : StringView { "DT_GNU_HASH", 11 }; + return HashSection(Section(*this, m_hash_table_offset, 0, 0, section_name), m_hash_type); + } RelocationSection relocation_section() const; RelocationSection plt_relocation_section() const; -- cgit v1.2.3