From 3052c0578cd9d4772fee925f50d14370cecda926 Mon Sep 17 00:00:00 2001 From: networkException Date: Thu, 17 Feb 2022 11:26:04 +0100 Subject: LibVT: Properly populate context menu with open actions We would previously overwrite m_hovered_href with tooltip texts instead of leaving it as an url as was expected by the context menu event handler. --- Userland/Libraries/LibVT/TerminalWidget.cpp | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) (limited to 'Userland/Libraries/LibVT/TerminalWidget.cpp') diff --git a/Userland/Libraries/LibVT/TerminalWidget.cpp b/Userland/Libraries/LibVT/TerminalWidget.cpp index 9c51cf93e8..57438b09c1 100644 --- a/Userland/Libraries/LibVT/TerminalWidget.cpp +++ b/Userland/Libraries/LibVT/TerminalWidget.cpp @@ -827,23 +827,21 @@ void TerminalWidget::mousemove_event(GUI::MouseEvent& event) if (attribute.href_id != m_hovered_href_id) { if (m_active_href_id.is_null() || m_active_href_id == attribute.href_id) { m_hovered_href_id = attribute.href_id; + m_hovered_href = attribute.href; + auto handlers = Desktop::Launcher::get_handlers_for_url(attribute.href); if (!handlers.is_empty()) { auto path = URL(attribute.href).path(); auto name = LexicalPath::basename(path); - if (path == handlers[0]) { - m_hovered_href = String::formatted("Execute {}", name); - } else { - m_hovered_href = String::formatted("Open {} with {}", name, LexicalPath::basename(handlers[0])); - } - } else { - m_hovered_href = attribute.href; + if (path == handlers[0]) + set_tooltip(String::formatted("Execute {}", name)); + else + set_tooltip(String::formatted("Open {} with {}", name, LexicalPath::basename(handlers[0]))); } } else { m_hovered_href_id = {}; m_hovered_href = {}; } - set_tooltip(m_hovered_href); show_or_hide_tooltip(); if (!m_hovered_href.is_empty()) set_override_cursor(Gfx::StandardCursor::Arrow); -- cgit v1.2.3