From afc86abe24d39add54ccc642cf6918d4bf626bdd Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Mon, 5 Apr 2021 18:04:55 +0200 Subject: LibJS: Remove this_object parameter from get/put own property functions Specifically: - Object::get_own_properties() - Object::put_own_property() - Object::put_own_property_by_index() These APIs make no sense (and are inconsistent, get_own_property() didn't have this parameter, for example) - and as expected we were always passing in the same object we were calling the method on anyway. --- Userland/Libraries/LibJS/Runtime/ObjectConstructor.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'Userland/Libraries/LibJS/Runtime/ObjectConstructor.cpp') diff --git a/Userland/Libraries/LibJS/Runtime/ObjectConstructor.cpp b/Userland/Libraries/LibJS/Runtime/ObjectConstructor.cpp index 4856b6ae21..88793ed56d 100644 --- a/Userland/Libraries/LibJS/Runtime/ObjectConstructor.cpp +++ b/Userland/Libraries/LibJS/Runtime/ObjectConstructor.cpp @@ -209,7 +209,7 @@ JS_DEFINE_NATIVE_FUNCTION(ObjectConstructor::keys) if (vm.exception()) return {}; - return obj_arg->get_own_properties(*obj_arg, PropertyKind::Key, true); + return obj_arg->get_own_properties(PropertyKind::Key, true); } JS_DEFINE_NATIVE_FUNCTION(ObjectConstructor::values) @@ -222,7 +222,7 @@ JS_DEFINE_NATIVE_FUNCTION(ObjectConstructor::values) if (vm.exception()) return {}; - return obj_arg->get_own_properties(*obj_arg, PropertyKind::Value, true); + return obj_arg->get_own_properties(PropertyKind::Value, true); } JS_DEFINE_NATIVE_FUNCTION(ObjectConstructor::entries) @@ -235,7 +235,7 @@ JS_DEFINE_NATIVE_FUNCTION(ObjectConstructor::entries) if (vm.exception()) return {}; - return obj_arg->get_own_properties(*obj_arg, PropertyKind::KeyAndValue, true); + return obj_arg->get_own_properties(PropertyKind::KeyAndValue, true); } } -- cgit v1.2.3