From cd0a1fa5b0d5b0dd245d384caecbc2500d9bdab7 Mon Sep 17 00:00:00 2001 From: Tom Date: Mon, 15 Feb 2021 20:05:49 -0700 Subject: LibGUI: Avoid needlessly copying vectors of rects --- Userland/Libraries/LibGUI/Window.cpp | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) (limited to 'Userland/Libraries/LibGUI/Window.cpp') diff --git a/Userland/Libraries/LibGUI/Window.cpp b/Userland/Libraries/LibGUI/Window.cpp index 1ad24ded63..a088d96db2 100644 --- a/Userland/Libraries/LibGUI/Window.cpp +++ b/Userland/Libraries/LibGUI/Window.cpp @@ -416,12 +416,8 @@ void Window::handle_multi_paint_event(MultiPaintEvent& event) else if (created_new_backing_store) set_current_backing_store(*m_back_store, true); - if (is_visible()) { - Vector rects_to_send; - for (auto& r : rects) - rects_to_send.append(r); - WindowServerConnection::the().post_message(Messages::WindowServer::DidFinishPainting(m_window_id, rects_to_send)); - } + if (is_visible()) + WindowServerConnection::the().post_message(Messages::WindowServer::DidFinishPainting(m_window_id, rects)); } void Window::handle_key_event(KeyEvent& event) @@ -606,10 +602,7 @@ void Window::update(const Gfx::IntRect& a_rect) auto rects = move(m_pending_paint_event_rects); if (rects.is_empty()) return; - Vector rects_to_send; - for (auto& r : rects) - rects_to_send.append(r); - WindowServerConnection::the().post_message(Messages::WindowServer::InvalidateRect(m_window_id, rects_to_send, false)); + WindowServerConnection::the().post_message(Messages::WindowServer::InvalidateRect(m_window_id, rects, false)); }); } m_pending_paint_event_rects.append(a_rect); -- cgit v1.2.3